Re: [PR] feat: Cache ballista clients on executor [datafusion-ballista]

["milenkovicm (via GitHub)" <gi...@apache.org>]

milenkovicm commented on code in PR #1578:
URL: https://github.com/apache/datafusion-ballista/pull/1578#discussion_r3160059645


##########
ballista/executor/src/executor.rs:
##########
@@ -127,7 +127,30 @@ impl Executor {
         function_registry: Arc<BallistaFunctionRegistry>,
         metrics_collector: Arc<dyn ExecutorMetricsCollector>,
         concurrent_tasks: usize,
-        execution_engine: Option<Arc<dyn ExecutionEngine>>,
+        execution_engine: Arc<dyn ExecutionEngine>,

Review Comment:
   its a minimal change, not many users use this api, I suggest to keep the change as it is, if you agree 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org