You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "laeubi (via GitHub)" <gi...@apache.org> on 2025/01/23 11:54:08 UTC
[PR] LOGGING-198 - add proper uses to export package [commons-logging]
laeubi opened a new pull request, #337:
URL: https://github.com/apache/commons-logging/pull/337
Currently there are no use clauses on the export package header, this can lead to classloading problems.
This now adds the appropriate use clause to the export header, due to a bug in commons-parent this currently can not be calculated automatically.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2621816998
If I download the snapshot I still see no `uses`:
```
Export-Package: org.apache.commons.logging;version="1.3.5.SNAPSHOT",
org.apache.commons.logging.impl;version="1.3.5.SNAPSHOT"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2644207425
@ppkarwasz Would you review the RC please? It looks like people affected by this issue would be able to move on if we wrap up the voting positively and release. Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643573935
Looking at the pictures it seems that the bundle ID changed from `org.apache.commons.logging` to `org.apache.commons.commons-logging`. We probably should fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #337: [LOGGING-198] Add proper OSGi uses to export package
URL: https://github.com/apache/commons-logging/pull/337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LOGGING-198 - add proper uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2609884935
> Looks good to me.
>
> I am just wondering if we can introduce some integration tests that prevent this issue from happening again.
Yes indeed. Please add something like https://github.com/apache/commons-compress/tree/master/src/test/java/org/apache/commons/compress/osgi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "merks (via GitHub)" <gi...@apache.org>.
merks commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643698742
Indeed people have accommodated the BSN change so further changes would be unhelpful at best and would make the update I showed as solving the problem more difficult...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2644262152
@garydgregory: it is done!
Somehow I thought that this PR was going into the release, my mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643174190
@laeubi
Please see https://lists.apache.org/thread/zlw67lmqmcs55x5hzv5gl7984x36z5gn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2644513077
> Closing: Version 1.3.5 is now available.
Many thanks! It is even already picket up as a new version here:
- https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/2811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2621844830
With a local build I see this:
```
Export-Package: org.apache.commons.logging;version="1.3.5.SNAPSHOT",org.
apache.commons.logging.impl;version="1.3.5.SNAPSHOT";uses:="javax.servl
et,org.apache.avalon.framework.logger,org.apache.commons.logging,org.ap
ache.log,org.apache.log4j"
```
so it looks like the snapshots are not yet updated!?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2622031794
> I'll cut a 1.3.5 release candidate over the next couple of days.
Great!
> Why do want a 1.2.x release?
Some people still use 1.2.x and it has the same problem in manifest
so we came up with version 1.2.x and 1.3.x used in the same framework and that was where I discovered the issue initially, but I can understand if you say they should better upgrade than care too much about old versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643182149
Thanks! I checked the jar there now and it looks fine:
```
Export-Package:
org.apache.commons.logging;version="1.3.5",
org.apache.commons.logging.impl;version="1.3.5";
uses:="javax.servlet,org.apache.avalon.framework.logger,org.apache.commons.logging,org.apache.log,org.apache.log4j"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2621882162
@garydgregory the download is looking good now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LOGGING-198 - add proper uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2609665753
I created a backport of this (but sadly there is no way to create a PR yet as no branch exits in this repo):
https://github.com/laeubi/commons-logging/tree/1.x
to create the [base branch](https://github.com/laeubi/commons-logging/commit/bd26f32b9a24e1c5176da719c95203bba09e401c) I did:
```
git fetch --all --tags
git checkout -b 1.x LOGGING_1_2
```
then applied [my changes](https://github.com/laeubi/commons-logging/commit/3f40bc503fcdc4a3c12fa6594aa5b5a4a2479310), so if the 1.x branch could be create in this repo I should be able to offer a PR for this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643598711
@laeubi,
The bundle ID changed between version 1.2.x and 1.3.x. Should we fix that?
```
Bundle-Name Apache Commons Logging
Bundle-SymbolicName org.apache.commons.logging
Bundle-Vendor The Apache Software Foundation
Bundle-Version 1.2.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2644436110
Closing: Version 1.3.5 is now available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2609914969
I don't think this is something I can offer here, it will require a whole bunch of setups and different version to actually show the problem of bad meta-data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2621787759
Hello @laeubi and all:
Please test 1.3.5-SNAPSHOT from https://repository.apache.org/content/repositories/snapshots/ or a local build from git master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2621987804
Is there any plans for a new 1.3.5 release?
And then only question remains is there any chance for a fix in the 1.2.x ... I assume the main problem would be to actually build the release, but it would also work to just download the old jar and update the manifest + version manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2621865791
Hi @laeubi
Please try again (https://repository.apache.org/content/repositories/snapshots/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643348071
Using Maven you can add a repository entry to point to the Apache Maven Snapshot repository as documented here: https://maven.apache.org/guides/mini/guide-multiple-repositories.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LOGGING-198 - add proper uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2609668195
@garydgregory can you take a look here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2609997566
> Are you saying that tests like the Commons Compress example would not catch this kind of issue? I guess we can't know until a test exists...
The commons compress test only the bundle itself, this issue you will only see when *different* bundles are used, e.g. to show the problem in this test you will need (or maybe similar):
1. this bundle in version 1.2 and 1.3
2. a bundle importing 1.2 api but 1.3 impl
3. a bundle using that bundle to emit a log message
What then (if anything setup correctly) will happen is that it gets wired to 1.2 API but 1.3 impl and when the log message is issued you will see `java.lang.ClassCastException` somewhere logged (maybe on system out) and you hopefully can capture this in an assert. So rather complex and convoluted setup ... I don't say its impossible but I question the usefulness, because once the problem is solved you won't be able to run the test anymore because then the OSGi framework itself will not run the test anymore because it detects the problem before and refuses to start the bundles at all :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643670136
As 1.3.x is around for a while an no one complained I would not change it now, one should actually always only import the package so the bundle-symbolic-name is not that important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643591417
## New Artifact
```
Bundle-Name: Apache Commons Logging
Bundle-SymbolicName: org.apache.commons.commons-logging
Bundle-Vendor: The Apache Software Foundation
Bundle-Version: 1.3.5
```
## Previous Artifact:
```
Bundle-Name: Apache Commons Logging
Bundle-SymbolicName: org.apache.commons.commons-logging
Bundle-Vendor: The Apache Software Foundation
Bundle-Version: 1.3.4
```
so it looks all fine for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2609938364
> I don't think this is something I can offer here, it will require a whole bunch of setups and different version to actually show the problem of bad meta-data.
Are you saying that tests like the Commons Compress example would not catch this kind of issue? I guess we can't know until a test exists...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2622021339
@laeubi
I'll cut a 1.3.5 release candidate over the next couple of days. Why do want a 1.2.x release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2622087089
@laeubi
Because a new version on a release line exists, it does not mean projects will update. Many projects still use the version of Log4j that has Log4Shell, despite fixes being available on all release lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "merks (via GitHub)" <gi...@apache.org>.
merks commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643355066
I can verify that in an environment with this problem:
```
java.lang.ExceptionInInitializerError
at org.apache.http.conn.ssl.SSLConnectionSocketFactory.<clinit>(SSLConnectionSocketFactory.java:151)
at org.eclipse.jgit.transport.http.apache.HttpClientConnectionFactory$HttpClientSession.configure(HttpClientConnectionFactory.java:89)
at org.eclipse.jgit.transport.http.apache.HttpClientConnectionFactory$HttpClientSession.configure(HttpClientConnectionFactory.java:1)
at org.eclipse.jgit.transport.TransportHttp.httpOpen(TransportHttp.java:1062)
at org.eclipse.jgit.transport.TransportHttp.connect(TransportHttp.java:651)
at org.eclipse.jgit.transport.TransportHttp.openFetch(TransportHttp.java:465)
at org.eclipse.jgit.transport.FetchProcess.executeImp(FetchProcess.java:153)
at org.eclipse.jgit.transport.FetchProcess.execute(FetchProcess.java:105)
at org.eclipse.jgit.transport.Transport.fetch(Transport.java:1458)
at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:238)
at org.eclipse.jgit.api.PullCommand.call(PullCommand.java:266)
at org.eclipse.egit.core.op.PullOperation$PullJob.run(PullOperation.java:256)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: org.apache.commons.logging.LogConfigurationException: The chosen LogFactory implementation does not extend LogFactory. Please check your configuration. (Caused by java.lang.ClassCastException: The application has specified that a custom LogFactory implementation should be used but Class 'org.apache.commons.logging.impl.LogFactoryImpl' cannot be converted to 'org.apache.commons.logging.LogFactory'. The conflict is caused by the presence of multiple LogFactory classes in incompatible classloaders. Background can be found in http://commons.apache.org/logging/tech.html. If you have not explicitly specified a custom LogFactory then it is likely that the container has set one without your knowledge. In this case, consider using the commons-logging-adapters.jar file or specifying the standard LogFactory from the command line. Help can be found @http://commons.apache.org/logging/troubleshooting.html.)
at org.apache.commons.logging.LogFactory.createFactory(LogFactory.java:1154)
at org.apache.commons.logging.LogFactory$2.run(LogFactory.java:960)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
at org.apache.commons.logging.LogFactory.newFactory(LogFactory.java:957)
at org.apache.commons.logging.LogFactory.getFactory(LogFactory.java:624)
at org.apache.commons.logging.LogFactory.getLog(LogFactory.java:655)
at org.apache.http.conn.ssl.AbstractVerifier.<init>(AbstractVerifier.java:61)
at org.apache.http.conn.ssl.AllowAllHostnameVerifier.<init>(AllowAllHostnameVerifier.java:44)
at org.apache.http.conn.ssl.AllowAllHostnameVerifier.<clinit>(AllowAllHostnameVerifier.java:46)
... 13 more
Caused by: java.lang.ClassCastException: The application has specified that a custom LogFactory implementation should be used but Class 'org.apache.commons.logging.impl.LogFactoryImpl' cannot be converted to 'org.apache.commons.logging.LogFactory'. The conflict is caused by the presence of multiple LogFactory classes in incompatible classloaders. Background can be found in http://commons.apache.org/logging/tech.html. If you have not explicitly specified a custom LogFactory then it is likely that the container has set one without your knowledge. In this case, consider using the commons-logging-adapters.jar file or specifying the standard LogFactory from the command line. Help can be found @http://commons.apache.org/logging/troubleshooting.html.
at org.apache.commons.logging.LogFactory.createFactory(LogFactory.java:1108)
... 21 more
```
that updating to the new 1.3.5 version:
Allows me to do a pull again,
I.e., this change definitely fixes the problem we had with the 1.3.4 version.
Woo hoo! 🥇 💟
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "merks (via GitHub)" <gi...@apache.org>.
merks commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643208879
In principle I should be able to use this:
https://repository.apache.org/content/repositories/orgapachecommons-1812/commons-logging/commons-logging/
I can build stuff locally for testing. I'm not sure how much work that will be. I'll see what I can do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LOGGING-198] Add proper OSGi uses to export package [commons-logging]
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #337:
URL: https://github.com/apache/commons-logging/pull/337#issuecomment-2643171004
@garydgregory I see there is a RC2 tag in the repository, but I can't see the RC on central:
https://repo1.maven.org/maven2/commons-logging/commons-logging/
is there some staging repo we can use for help testing?
FYI @merks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org