You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/28 01:28:37 UTC

[GitHub] [pulsar] shibd commented on pull request #18380: [fix][broker] WaitForExclusive should fenced when exist Shared producer.

shibd commented on PR #18380:
URL: https://github.com/apache/pulsar/pull/18380#issuecomment-1366302118

   @eolivelli Thanks for your reply.
   
   > I think that we should behave like Exclusive and ExclusiveWithFencing: if there are Shared producers they must be disconnected and fail
   
   In fact, Exclusive's current behavior is that when it encounters has shared producer, it will fence itself.
   
   https://github.com/apache/pulsar/blob/5b062f37bd6688c09384abbe908f7c14e28052fc/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java#L752-L754
   
   In my opinion, this scenario occurs when the user connects to the wrong topic. We should tell Exclusive/WaitForExclusive producers about the exception of existing shared producers, rather than fence existing shared producers.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org