You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/14 07:25:24 UTC
[GitHub] [apisix] biubiue opened a new pull request #6107: fix(ssl): radixtree_sni.lua
biubiue opened a new pull request #6107:
URL: https://github.com/apache/apisix/pull/6107
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] biubiue commented on a change in pull request #6107: fix(ssl): radixtree_sni.lua
Posted by GitBox <gi...@apache.org>.
biubiue commented on a change in pull request #6107:
URL: https://github.com/apache/apisix/pull/6107#discussion_r784619772
##########
File path: apisix/ssl/router/radixtree_sni.lua
##########
@@ -104,7 +104,7 @@ local function set_pem_ssl_key(sni, cert, pkey)
end
local parsed_pkey, err = apisix_ssl.fetch_pkey(sni, pkey)
- if not parsed_cert then
+ if not parsed_pkey then
return false, "failed to parse PEM priv key: " .. err
Review comment:
sorry,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6107: fix(ssl): correct variable name in radixtree_sni.lua
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6107:
URL: https://github.com/apache/apisix/pull/6107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] biubiue commented on a change in pull request #6107: fix(ssl): radixtree_sni.lua
Posted by GitBox <gi...@apache.org>.
biubiue commented on a change in pull request #6107:
URL: https://github.com/apache/apisix/pull/6107#discussion_r784628597
##########
File path: apisix/ssl/router/radixtree_sni.lua
##########
@@ -104,7 +104,7 @@ local function set_pem_ssl_key(sni, cert, pkey)
end
local parsed_pkey, err = apisix_ssl.fetch_pkey(sni, pkey)
- if not parsed_cert then
+ if not parsed_pkey then
return false, "failed to parse PEM priv key: " .. err
Review comment:
I can't write unit tests, I'm developing in a window environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #6107: fix(ssl): radixtree_sni.lua
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #6107:
URL: https://github.com/apache/apisix/pull/6107#discussion_r784611805
##########
File path: apisix/ssl/router/radixtree_sni.lua
##########
@@ -104,7 +104,7 @@ local function set_pem_ssl_key(sni, cert, pkey)
end
local parsed_pkey, err = apisix_ssl.fetch_pkey(sni, pkey)
- if not parsed_cert then
+ if not parsed_pkey then
return false, "failed to parse PEM priv key: " .. err
Review comment:
do you have time to add a test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org