[jira] [Commented] (LANG-805) RandomStringUtils.random(count, 0, 0, false, false, universe, random) always throws java.lang.ArrayIndexOutOfBoundsException

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LANG-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292352#comment-13292352 ] 

Sebb commented on LANG-805:
---------------------------

Alternatively, choose end = chars.length.

In any case, the code needs to check for chars.length == 0 to avoid NPE in the modulus or IAE in random.nextInt(gap) as gap will be zero.
                
> RandomStringUtils.random(count, 0, 0, false, false, universe, random) always throws java.lang.ArrayIndexOutOfBoundsException
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LANG-805
>                 URL: https://issues.apache.org/jira/browse/LANG-805
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.5, 2.6
>            Reporter: Thomas BELOT
>            Priority: Blocker
>              Labels: patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In commons-lang 2.6 line 250 :
> {code}ch = chars[random.nextInt(gap) + start];{code}
> This line of code takes a random int to fetch a char in the _chars_ array regardless of it's size.
> (Besides _start_ is useless here)
> Fixed version would be : 
> {code}ch = chars[random.nextInt(gap)%chars.length];{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira