You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/10/23 07:19:00 UTC

[GitHub] [thrift] fishy commented on a diff in pull request #2718: THRIFT-5650: Implement UUID in Go compiler

fishy commented on code in PR #2718:
URL: https://github.com/apache/thrift/pull/2718#discussion_r1002654203


##########
lib/go/thrift/json_protocol.go:
##########
@@ -524,6 +524,8 @@ func (p *TJSONProtocol) TypeIdToString(fieldType TType) (string, error) {
 		return "set", nil
 	case LIST:
 		return "lst", nil
+	case UUID:
+		return "uid", nil

Review Comment:
   apparently we don't have a written spec for TJSONProtocol, so I followed this part from the implementation of java library.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org