[GitHub] [airflow] kaxil commented on a change in pull request #7735: [AIRFLOW-4549] Allow skipped tasks to satisfy wait_for_downstream

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #7735:
URL: https://github.com/apache/airflow/pull/7735#discussion_r420652841



##########
File path: tests/models/test_taskinstance.py
##########
@@ -855,6 +855,25 @@ def test_check_task_dependencies(self, trigger_rule, successes, skipped,
         self.assertEqual(completed, expect_completed)
         self.assertEqual(ti.state, expect_state)
 
+    @parameterized.expand([

Review comment:
       There was another test in the original PR:
   
   ```python
       def test_respects_prev_dagrun_dep(self):
           dag = models.DAG(dag_id='test_dag')
           task = DummyOperator(dag=dag, task_id='test_task', start_date=DEFAULT_DATE)
           ti = TI(task, DEFAULT_DATE)
           failing_status = [TIDepStatus('test fail status name', False, 'test fail reason')]
           passing_status = [TIDepStatus('test pass status name', True, 'test passing reason')]
           with patch('airflow.ti_deps.deps.prev_dagrun_dep.PrevDagrunDep.get_dep_statuses',
                      return_value=failing_status):
               self.assertFalse(ti.are_dependencies_met())
           with patch('airflow.ti_deps.deps.prev_dagrun_dep.PrevDagrunDep.get_dep_statuses',
                      return_value=passing_status):
               self.assertTrue(ti.are_dependencies_met())
   ```
   
   Any reason why we didn't include it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org