You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/10 06:59:36 UTC

[GitHub] [camel] jam01 opened a new pull request #4747: revert CAMEL-15710

jam01 opened a new pull request #4747:
URL: https://github.com/apache/camel/pull/4747


   In order to enable extending camel-created spans in processors, PR https://github.com/apache/camel/pull/4497 introduced functionality that was already present through a configurable `InterceptStrategy` though it was undocumented (my fault).This PR takes care of reverting those changes and adds documentation, while preserving the added test in order to prove the functionality is the same.
   
   @orange-buffalo please take a look. You'll notice that the only modification to the test is that now we have one extra span for each route execution, this is the span for the single processor in the route.
   
   @oscerd I know you guys are preparing the 3.7 release, I'm hoping we can squeeze in this fix. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orange-buffalo commented on pull request #4747: revert CAMEL-15710

Posted by GitBox <gi...@apache.org>.
orange-buffalo commented on pull request #4747:
URL: https://github.com/apache/camel/pull/4747#issuecomment-742801208


   Thanks @jam01!
   I think it could be a nice improvement for Camel to provide this via Open Tracing auto-configuration and lookup the tracer / strategy from the context. 
   Anyway, thanks again for the hint!  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jam01 commented on pull request #4747: revert CAMEL-15710

Posted by GitBox <gi...@apache.org>.
jam01 commented on pull request #4747:
URL: https://github.com/apache/camel/pull/4747#issuecomment-742797965


   Hey @orange-buffalo we have this in our `@SpringBootApplication`
   
   ```
   	@Bean
   	public Tracer tracer() {
   		OpenTracingTracer answer = new OpenTracingTracer();
   		answer.setTracer(io.jaegertracing.Configuration.fromEnv().getTracer());
   		answer.setTracingStrategy(new OpenTracingTracingStrategy(answer));
   
   		return answer;
   	}
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #4747: revert CAMEL-15710

Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4747:
URL: https://github.com/apache/camel/pull/4747


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #4747: revert CAMEL-15710

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4747:
URL: https://github.com/apache/camel/pull/4747#issuecomment-742328097


   yeah fine with me


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orange-buffalo commented on pull request #4747: revert CAMEL-15710

Posted by GitBox <gi...@apache.org>.
orange-buffalo commented on pull request #4747:
URL: https://github.com/apache/camel/pull/4747#issuecomment-742795694


   @jam01, can you please give us a hint how `InterceptStrategy` can be configured when using Camel with Spring Boot? Does Camel lookup this strategy from the registry when tracer is initialized?  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org