You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/14 18:44:42 UTC
[jira] [Commented] (THRIFT-4091) Removed unused realloc test
causing autoconf warnings at bootstrap time
[ https://issues.apache.org/jira/browse/THRIFT-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866371#comment-15866371 ]
ASF GitHub Bot commented on THRIFT-4091:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1192
THRIFT-4091 - revert THRIFT-4045 (bad change) and remove unused test code in test/cpp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4091
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1192
----
commit 80f76e835219e5dc450870f93c1dd9511594eb39
Author: James E. King, III <ji...@simplivity.com>
Date: 2017-02-14T17:50:45Z
THRIFT-4091 - revert THRIFT-4045 and remove unused test code in test/cpp
----
> Removed unused realloc test causing autoconf warnings at bootstrap time
> -----------------------------------------------------------------------
>
> Key: THRIFT-4091
> URL: https://issues.apache.org/jira/browse/THRIFT-4091
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: Ubuntu 14.04
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Trivial
>
> Following THRIFT-4045 bootstrap posts a couple warnings:
> {noformat}
> configure.ac: warning: missing AC_FUNC_MALLOC wanted by: test/cpp/realloc/realloc_test.c:99
> configure.ac: warning: missing AC_FUNC_REALLOC wanted by: test/cpp/realloc/realloc_test.c:29
> {noformat}
> This test is not built or used so it can be removed. Removing the test uncovers others, so THRIFT-4045 is a bad fix. Revert it and provide guidance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)