[GitHub] [superset] villebro commented on a change in pull request #17984: fix: Change default SECRET_KEY, improve docs and banner warning on de…

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #17984:
URL: https://github.com/apache/superset/pull/17984#discussion_r781931628



##########
File path: superset/initialization/__init__.py
##########
@@ -572,12 +573,27 @@ def init_app_in_ctx(self) -> None:
 
         self.init_views()
 
+    def check_secret_key(self) -> None:
+        if self.config["SECRET_KEY"] == CHANGE_ME_SECRET_KEY:
+            top_banner = 80 * "-" + "\n" + 36 * " " + "WARNING\n" + 80 * "-"
+            bottom_banner = 80 * "-" + "\n" + 80 * "-"
+            logger.warning(top_banner)
+            logger.warning(
+                "A Default SECRET_KEY was detected please use superset_config.py "

Review comment:
       nit:
   ```suggestion
                   "A Default SECRET_KEY was detected, please use superset_config.py "
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org