[GitHub] [zookeeper] symat opened a new pull request #1159: ZOOKEEPER-3630: Autodetection of openssl during ZooKeeper C client build

[GitBox <gi...@apache.org>]

symat opened a new pull request #1159: ZOOKEEPER-3630: Autodetection of openssl during ZooKeeper C client build
URL: https://github.com/apache/zookeeper/pull/1159
 
 
   **Thanks for @ztzg for raising the issue and suggesting the solution!**
   
   In this patch we enhance the way how the openssl library is found during C client build. I introduced  and documented a new build parameter for `configure` (`--with-openssl=...`), `cmake` (`-D WITH_OPENSSL=...`) and `mvn` (`-Dc-client-openssl=...`), so independent of the build tool, the build will work the same way:
   - By default, the OpenSSL library will be autodetected. If the library is found, then the C-client will be compiled with SSL support, otherwise we get a warning message, but the build will continue without SSL support. The SSL related unit tests will be skipped as well.
   - you can explicitly disable the SSL support (e.g. `-Dc-client-openssl=no`)
   - or you can specify an alternative path to look for the openssl library (e.g. `-Dc-client-openssl=/path/to/openssl`)
   
   I tested the patch
   - using mvn on linux
   - using make on linux
   - using cmake on linux or windows
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services