[jira] [Commented] (OOZIE-994) ActionCheckXCommand does not handle failures properly

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459389#comment-13459389 ] 

Hadoop QA commented on OOZIE-994:
---------------------------------

Testing JIRA OOZIE-994

Cleaning local svn workspace

{code}
----------------------------

+1 PATCH_APPLIES
   CLEAN cleaned target directories
-1 RAW_PATCH_ANALYSIS
    +1 the patch does not introduce any @author tags
    +1 the patch does not introduce any tabs
    +1 the patch does not introduce any trailing spaces
    -1 the patch contains 1 line(s) longer than 132 characters
    +1 the patch does adds/modifies 3 testcase(s)
+1 RAT
    +1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
    +1 the patch does not seem to introduce new Javadoc warnings
+1 COMPILE
    +1 HEAD compiles
    +1 patch compiles
    +1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
    +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
    +1 the patch does not modify JPA files
+1 TESTS
   Tests run: 912
   Tests failures: 0
   Tests errors: 0
+1 DISTRO
    +1 distro tarball builds with the patch 

----------------------------
{code}

The full output of the test-patch run is available at

   https://builds.apache.org/job/oozie-trunk-precommit-build/105/
                
> ActionCheckXCommand does not handle failures properly
> -----------------------------------------------------
>
>                 Key: OOZIE-994
>                 URL: https://issues.apache.org/jira/browse/OOZIE-994
>             Project: Oozie
>          Issue Type: Bug
>          Components: workflow
>    Affects Versions: 3.2.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Robert Kanter
>            Priority: Critical
>             Fix For: trunk
>
>         Attachments: OOZIE-994.patch
>
>
> If the JT restarts or dies and running jobs are lost or the JT is not reachable, Oozie ActionCheckXCommand will never fail the workflow job.
> There seem to be 2 issues here:
> * convertException is not receiving the root cause exception anytmore, but alway HadoopAccessorException wrapping the root cause exception. We should modify the convertException to inspect the cause exception as well.
> * ActionCheckXCommand does not do the handle retry logic of ActionStartXCommand.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira