You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/31 06:51:32 UTC

[GitHub] [airflow] milton0825 commented on a change in pull request #5350: [AIRFLOW-4716] Instrument dag loading time duration

milton0825 commented on a change in pull request #5350: [AIRFLOW-4716] Instrument dag loading time duration
URL: https://github.com/apache/airflow/pull/5350#discussion_r289275017
 
 

 ##########
 File path: airflow/models/dagbag.py
 ##########
 @@ -391,6 +391,10 @@ def collect_dags(
             'dagbag_import_errors', len(self.import_errors), 1)
         self.dagbag_stats = sorted(
             stats, key=lambda x: x.duration, reverse=True)
+        for file_stat in self.dagbag_stats:
+            Stats.timing('dag.loading-duration.{}'.
+                         format(file_stat.dags),
 
 Review comment:
   I think it is possible that we have multiple `DAG` s created in a file and that may break the stats name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services