You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Andrew Sherman (JIRA)" <ji...@apache.org> on 2018/03/02 22:07:00 UTC

[jira] [Commented] (HIVE-18791) Fix TestJdbcWithMiniHS2#testHttpHeaderSize

    [ https://issues.apache.org/jira/browse/HIVE-18791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384218#comment-16384218 ] 

Andrew Sherman commented on HIVE-18791:
---------------------------------------

The test TestJdbcWithMiniHS2.testHttpHeaderSize() is testing that HS2 can be reconfigured
to use different maximum sizes of http headers when Thrift uses http as its transport.
In this mode the http header contains a user name and password encoded using http basic
encoding. The original test varies the length of the user name to test (1) that that a
too large header fails with 413 Payload Too Large, and (2) that increasing the maximum
sizes of http headers allows the large header to work. In HS2 when the connection is made
a Session is created (note that in this configuration the user name and password are not
verified). The local scratch directory for the session uses the username as part of its
path. When this name is more than 255 chars (on most modern file systems) then the
directory creation will fail. HIVE-18625 made this failure newly throw an exception, which
caused a regression in testHttpHeaderSize() when the session was created with a long user
name. Fix this by having the test vary the password rather then the user name. The test
is functionally identical but does not hit the directory creation exception.

> Fix TestJdbcWithMiniHS2#testHttpHeaderSize
> ------------------------------------------
>
>                 Key: HIVE-18791
>                 URL: https://issues.apache.org/jira/browse/HIVE-18791
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Andrew Sherman
>            Assignee: Andrew Sherman
>            Priority: Major
>
> TestJdbcWithMiniHS2#testHttpHeaderSize tests whether config of http header sizes works by using a long username. The local scratch directory for the session uses the username as part of its path. When this name is more than 255 chars (on most modern file systems) then the directory creation will fail. HIVE-18625 made this failure throw an exception, which has caused a regression in testHttpHeaderSize.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)