You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/19 06:46:04 UTC
[GitHub] [apisix-docker] gxthrj opened a new pull request #133: feat: add apisix-docker test ci & modify centos dockerfile to solve openssl dependency
gxthrj opened a new pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133
…penssl dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r579589307
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] starsz commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r579817142
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ services:
+ etcd:
+ image: bitnami/etcd:3.4.13
+ ports:
+ - 2379:2379
+ - 2380:2380
+ env:
+ ALLOW_NONE_AUTHENTICATION: yes
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and Test
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker run -v `pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -d apisix:alpine
+ sleep 30
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
Review comment:
Is it for debug? If so, we can delete it.
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,31 @@
+name: APISIX Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and run
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker-compose -f ./alpine/docker-compose.yaml up -d
+ sleep 30
+ docker logs docker_apisix_1
+
+ - name: Test
+ run: |
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
+ code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code} http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1')
+ if [ ! $code -eq 200 ]; then
Review comment:
IMO, the test is a little bit easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r580006125
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,31 @@
+name: APISIX Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and run
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker-compose -f ./alpine/docker-compose.yaml up -d
+ sleep 30
+ docker logs docker_apisix_1
+
+ - name: Test
+ run: |
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
+ code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code} http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1')
+ if [ ! $code -eq 200 ]; then
Review comment:
Just a smoking here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r580861557
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ services:
+ etcd:
+ image: bitnami/etcd:3.4.13
+ ports:
+ - 2379:2379
+ - 2380:2380
+ env:
+ ALLOW_NONE_AUTHENTICATION: yes
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and Test
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker run -v `pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -d apisix:alpine
+ sleep 30
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
Review comment:
Have changed to route test
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,31 @@
+name: APISIX Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and run
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker-compose -f ./alpine/docker-compose.yaml up -d
+ sleep 30
+ docker logs docker_apisix_1
+
+ - name: Test
+ run: |
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
+ code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code} http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1')
+ if [ ! $code -eq 200 ]; then
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r579589434
##########
File path: example/docker-compose.yml
##########
@@ -2,7 +2,7 @@ version: "3"
services:
apisix:
- image: apache/apisix:2.3-alpine
+ image: apache/apisix:2.3-centos
Review comment:
Revert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r580730080
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,31 @@
+name: APISIX Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and run
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker-compose -f ./alpine/docker-compose.yaml up -d
+ sleep 30
+ docker logs docker_apisix_1
+
+ - name: Test
+ run: |
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
+ code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code} http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1')
+ if [ ! $code -eq 200 ]; then
Review comment:
OK, will change to route test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r579584553
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ services:
+ etcd:
+ image: bitnami/etcd:3.4.13
+ ports:
+ - 2379:2379
+ - 2380:2380
+ env:
+ ALLOW_NONE_AUTHENTICATION: yes
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and Test
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker run -v `pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -d apisix:alpine
+ sleep 30
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
Review comment:
View the returned data for the first time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r579102745
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test
Review comment:
Use `APISIX` instead of `apisix` in title.
##########
File path: example/docker-compose.yml
##########
@@ -2,7 +2,7 @@ version: "3"
services:
apisix:
- image: apache/apisix:2.3-alpine
+ image: apache/apisix:2.3-centos
Review comment:
What's the purpose of this change?
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ services:
+ etcd:
+ image: bitnami/etcd:3.4.13
+ ports:
+ - 2379:2379
+ - 2380:2380
+ env:
+ ALLOW_NONE_AUTHENTICATION: yes
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and Test
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker run -v `pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -d apisix:alpine
+ sleep 30
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
Review comment:
Why calling curl twice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r580006006
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ services:
+ etcd:
+ image: bitnami/etcd:3.4.13
+ ports:
+ - 2379:2379
+ - 2380:2380
+ env:
+ ALLOW_NONE_AUTHENTICATION: yes
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and Test
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker run -v `pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -d apisix:alpine
+ sleep 30
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
Review comment:
If there is something wrong, the return data can help us to locate the problem quickly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] starsz commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r580815925
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,31 @@
+name: APISIX Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and run
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker-compose -f ./alpine/docker-compose.yaml up -d
+ sleep 30
+ docker logs docker_apisix_1
+
+ - name: Test
+ run: |
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
+ code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code} http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1')
+ if [ ! $code -eq 200 ]; then
Review comment:
How is it going?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] starsz commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r580018510
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,31 @@
+name: APISIX Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and run
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker-compose -f ./alpine/docker-compose.yaml up -d
+ sleep 30
+ docker logs docker_apisix_1
+
+ - name: Test
+ run: |
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
+ code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code} http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1')
+ if [ ! $code -eq 200 ]; then
Review comment:
Yes. But I think we can test the route.
Refer: https://github.com/api7/apisix-build-tools/pull/14/files#diff-1e94407ae9a7cfa3661dbeeff2953068de2c2b999abb124e26ab7fd62830fb13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a change in pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133#discussion_r579601986
##########
File path: .github/workflows/apisix-alpine-docker-test.yaml
##########
@@ -0,0 +1,35 @@
+name: apisix Alpine docker Test
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ services:
+ etcd:
+ image: bitnami/etcd:3.4.13
+ ports:
+ - 2379:2379
+ - 2380:2380
+ env:
+ ALLOW_NONE_AUTHENTICATION: yes
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Build and Test
+ run: |
+ docker build -t apisix:alpine -f ./alpine/Dockerfile .
+ docker run -v `pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -d apisix:alpine
+ sleep 30
+ curl http://127.0.0.1:9080/apisix/admin/schema/service -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
Review comment:
I think it's unnecessary in CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj merged pull request #133: CI: add apisix-docker test
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #133:
URL: https://github.com/apache/apisix-docker/pull/133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org