You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/07 06:21:17 UTC

[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #11817: [Doc][Python] yaml_define examples link error

zhongjiajie commented on code in PR #11817:
URL: https://github.com/apache/dolphinscheduler/pull/11817#discussion_r964426035


##########
dolphinscheduler-python/pydolphinscheduler/docs/source/tutorial.rst:
##########
@@ -38,7 +38,7 @@ There are two types of tutorials: traditional and task decorator.
   supported. But it is helpful if your workflow is all built with Python or if you already have some Python
   workflow code and want to migrate them to pydolphinscheduler.
 - **YAML File**: We can use pydolphinscheduler CLI to create process using YAML file: :code:`pydolphinscheduler yaml -f tutorial.yaml`. 
-  We can find more YAML file examples in `examples/yaml_define <https://github.com/apache/dolphinscheduler/tree/py-yaml/dolphinscheduler-python/pydolphinscheduler/examples/yaml_define>`_
+  We can find more YAML file examples in `examples/yaml_define <https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-python/pydolphinscheduler/examples/yaml_define>`_

Review Comment:
   we should not use whole link in `rst` file, we should better use `:ref:` syntax for hyper link. Such as https://github.com/apache/dolphinscheduler/blob/3025f67d370e02ebae075a4ef68e1d7f0461b2d6/dolphinscheduler-python/pydolphinscheduler/docs/source/cli.rst#L26 is show 
   
   ```rst
   :ref:`install PyDolphinScheduler <start:installing pydolphinscheduler>`
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org