[GitHub] gianm commented on a change in pull request #6939: Throw caught exception.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6939: Throw caught exception.
URL: https://github.com/apache/incubator-druid/pull/6939#discussion_r252778646
 
 

 ##########
 File path: extensions-contrib/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegmentFinder.java
 ##########
 @@ -135,8 +135,7 @@ public GoogleDataSegmentFinder(
       throw new SegmentLoadingException(e, "IO exception");
     }
     catch (Exception e) {
-      Throwables.propagateIfInstanceOf(e, SegmentLoadingException.class);
-      Throwables.propagate(e);
+      throw Throwables.propagate(e);
 
 Review comment:
   We need to keep the `Throwables.propagateIfInstanceOf`. Removing it changes the behavior to no longer throw `SegmentLoadingException`, which introduces bugs downstream since some callers specifically try to catch that exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org