You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/04/10 13:51:43 UTC
[GitHub] [metron] ruffle1986 commented on a change in pull request #1375:
METRON-2060 Improving Alerts table config pane
ruffle1986 commented on a change in pull request #1375: METRON-2060 Improving Alerts table config pane
URL: https://github.com/apache/metron/pull/1375#discussion_r273969642
##########
File path: metron-interface/metron-alerts/src/app/alerts/configure-table/configure-table.component.ts
##########
@@ -165,21 +168,18 @@ export class ConfigureTableComponent implements OnInit, AfterViewInit {
}
save() {
- let selectedColumns = this.allColumns.filter((mDataWrapper: ColumnMetadataWrapper) => mDataWrapper.selected)
- .map((mDataWrapper: ColumnMetadataWrapper) => mDataWrapper.columnMetadata);
-
- this.configureTableService.saveColumnMetaData(selectedColumns).subscribe(() => {
- this.saveColumnNames();
- }, error => {
- console.log('Unable to save column preferences ...');
- this.saveColumnNames();
- });
-
-
+ this.configureTableService.saveColumnMetaData(
+ this.visibleColumns.map(columnMetaWrapper => columnMetaWrapper.columnMetadata))
+ .subscribe(() => {
+ this.saveColumnNames();
+ }, error => {
+ console.log('Unable to save column preferences ...');
Review comment:
shouldn't it be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services