[GitHub] incubator-flink pull request: [FLINK-924] Add automatic dependency...

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/35#issuecomment-63637840
  
    @qmlmoon Here are a few more details of what I think would be good to change / add as tests:
    
    1.  The ASM dependency you added conflicts with other transitive ASM depencencies, which are 4.x . We need a dependency management entry for this, and verify that the other dependencies (that themselves depend on ASM 4.x) work well with that higher version of ASM.
    
    2.  A test in the java8 project that uses a lambda with dependency:
    
    ```java
    ...
    FilerFunction<Long> filter = (v) -> v > 10;
    DataSet<Long> = someData.filter(filter);
    ...
    ```
    as well as
    ```java
    ...
    DataSet<Long> = someData.filter( (v) -> v > 10 );
    ...
    ```
    and
    ```java
    ...
    class UtilFunctions {
      public static FilterFunction<Long> getThresholdFilter(long threshold) {
        return (v) -> v > threshold;
      }
    }
    
    public static void main(String[] args) {
      ...
      DataSet<Long> = someData.filter(UtilFunctions.getThresholdFilter(10));
      ...
    }
    ...
    ```
    
    3.  The last case could be added also as a test for functions through inner classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---