You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by thehuijb <gi...@git.apache.org> on 2015/02/20 17:08:10 UTC
[GitHub] cordova-plugin-camera pull request: Fix issue where android cordov...
GitHub user thehuijb opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/65
Fix issue where android cordova app crashes on selecting images from dropbox
Cordova android apps would crash if you picked an image from a remote system e.g. Drive, OneDrive, Mega, Dropbox.
this pull request addresses that issue and also makes for more generic error messages, easier to handle in the callback method.
furthermore I added an option to getImages from only a dedicated gallery type app so if you want the user to specifically get pictures from the gallery `onlyGalleries` you can now enforce this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thehuijb/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit 2df903ae611e1961968e85f75d0fe56c9ee11371
Author: Serge Huijben <th...@gmail.com>
Date: 2015-02-19T23:32:31Z
more distinguishable error messages
enable dropbox images (won't crash the app anymore)
option to choose only from gallery apps, to stop people from introducing new problems
commit 0b3a9670f3202993cc510d307ee871c7137cd434
Author: Serge Huijben <th...@gmail.com>
Date: 2015-02-19T23:40:22Z
Merge pull request #1 from thehuijb/feature/android-stop-crashes-when-selecting-dropbox-image
more distinguishable error messages
commit 4636cbe2565406a36e4165662ba445c72bec1940
Author: Serge Huijben <th...@gmail.com>
Date: 2015-02-20T09:07:21Z
add doc for added property onlyGalleries
commit b28651c9cf5e0d33c2f0ca5ad9183da21e993e80
Author: Serge Huijben <th...@gmail.com>
Date: 2015-02-20T15:05:10Z
Merge pull request #2 from thehuijb/feature/android-stop-crashes-when-selecting-dropbox-image
add doc for added property onlyGalleries
commit 8176ba3160ee2d5860c9adcace2dcfc4eb4c0806
Author: Serge Huijben <th...@gmail.com>
Date: 2015-02-20T15:58:50Z
edit index.md
commit e2d655552bc24bdcf52f96ea924e65c9bed94cb5
Author: Serge Huijben <th...@gmail.com>
Date: 2015-02-20T15:59:26Z
Merge pull request #3 from thehuijb/feature/android-stop-crashes-when-selecting-dropbox-image
edit index.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix issue where android cordov...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/65#issuecomment-77190993
Change looks awesome! It's a bit much to pull in all at once though. Could you rebase this into three distinct commits (error msgs, dropbox fix, gallery param)?
Wondering if you'd also like to send a PR to improve the URL->filePath logic in cordova-android's [CordovaResourceApi class](https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaResourceApi.java#L143)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix issue where android cordov...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/65
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix issue where android cordov...
Posted by thehuijb <gi...@git.apache.org>.
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/65#issuecomment-77273772
reduced the pull request to only fix the https://issues.apache.org/jira/browse/CB-8235 issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix issue where android cordov...
Posted by thehuijb <gi...@git.apache.org>.
Github user thehuijb commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/65#issuecomment-77215024
I'll see what I can do
Op wo 4 mrt. 2015 om 17:28 schreef agrieve <no...@github.com>
> Change looks awesome! It's a bit much to pull in all at once though. Could
> you rebase this into three distinct commits (error msgs, dropbox fix,
> gallery param)?
>
> Wondering if you'd also like to send a PR to improve the URL->filePath
> logic in cordova-android's CordovaResourceApi class
> <https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaResourceApi.java#L143>
> ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-camera/pull/65#issuecomment-77190993>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org