You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/09/08 13:10:41 UTC

[GitHub] [nifi] MikeThomsen commented on a change in pull request #4951: NIFI-8376: Gracefully handle SQL exceptions in ResultSetRecordSet

MikeThomsen commented on a change in pull request #4951:
URL: https://github.com/apache/nifi/pull/4951#discussion_r704388164



##########
File path: nifi-commons/nifi-record/src/test/java/org/apache/nifi/serialization/record/ResultSetRecordSetTest.java
##########
@@ -241,6 +243,45 @@ public void testCreateRecord() throws SQLException {
         assertEquals(bigDecimal5Value, record.getValue(COLUMN_NAME_BIG_DECIMAL_5));
     }
 
+    @Test(expected = SQLException.class)

Review comment:
       I think SQLException is fine, and we can fold this into the nifi-commons JUnit 5 PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org