[GitHub] [flink-connector-hbase] ferenc-csaky commented on a diff in pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Fix hbase-client 2.2 dependency handling

[GitBox <gi...@apache.org>]

ferenc-csaky commented on code in PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#discussion_r1045091779


##########
flink-connector-hbase-2.2/pom.xml:
##########
@@ -152,6 +148,18 @@ under the License.
 					<groupId>org.apache.hadoop</groupId>
 					<artifactId>hadoop-hdfs</artifactId>
 				</exclusion>
+				<exclusion>
+					<groupId>org.apache.commons</groupId>
+					<artifactId>commons-lang3</artifactId>
+				</exclusion>
+				<exclusion>
+					<groupId>commons-io</groupId>
+					<artifactId>commons-io</artifactId>
+				</exclusion>
+				<exclusion>
+					<groupId>org.jruby.jcodings</groupId>
+					<artifactId>jcodings</artifactId>
+				</exclusion>

Review Comment:
   Both are excluded to achieve dependency convergence, but I reworked this part a bit now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org