[GitHub] [airflow] potiuk commented on a change in pull request #6376: [AIRFLOW-5705] Add creds backend and support for AWS SSM

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #6376: [AIRFLOW-5705] Add creds backend and support for AWS SSM
URL: https://github.com/apache/airflow/pull/6376#discussion_r389332786
 
 

 ##########
 File path: airflow/creds/__init__.py
 ##########
 @@ -0,0 +1,74 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""
+Creds framework provides means of getting connection objects from various sources e.g. the following:
+* Environment variables
+* Metatsore database
+* AWS SSM Parameter store
+"""
+
+from abc import ABC, abstractmethod
+from typing import List
+
+from airflow import AirflowException, conf
+from airflow.models import Connection
+from airflow.utils.module_loading import import_string
+
+CONN_ENV_PREFIX = "AIRFLOW_CONN_"
+
+
+class BaseCredsBackend(ABC):
+    """
+    Abstract base class to provide connection objects given a conn_id
 
 Review comment:
   I like Credentials name in this context and with the updated description
   
   I think it's a nice distinction - Connections are stored in Airflow DB or variable and Credentials are a way to retrieve the connections. But I can be convinced otherwise.
   
   Another option is to simply make it "SecretsBackend". I think that would be more generic and we could even provide a more generic interface to it, allowing to not only retrieve connections. I will discuss it at the devlist.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services