[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2088: Refactor: enhance the dockerfile

[GitBox <gi...@apache.org>]

terrymanu commented on issue #2088: Refactor: enhance the dockerfile
URL: https://github.com/apache/incubator-shardingsphere/pull/2088#issuecomment-476262999
 
 
   This is a good idea.
   For apache release, the distribution file is in `https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/${CURRENT_VERSION}/apache-shardingsphere-incubating-${CURRENT_VERSION}-sharding-proxy.tar.gz` temporary, and will move to `https://dist.apache.org/repos/dist/release/incubator/shardingsphere/${CURRENT_VERSION}/apache-shardingsphere-incubating-${CURRENT_VERSION}-sharding-proxy.tar.gz`
   
   So I suggest wget this file to instead of `https://raw.githubusercontent.com/apache/incubator-shardingsphere-doc/master/dist/${CURRENT_VERSION}.tar.gz`.
   
   Another suggest, `${CURRENT_VERSION}.tar.gz` is a file, use `rm -f` is better than `rm -rf`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services