You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/08 21:45:49 UTC

[GitHub] [beam] ibzib commented on a diff in pull request #16928: [BEAM-11971] Re add reverted timer consistency PR

ibzib commented on code in PR #16928:
URL: https://github.com/apache/beam/pull/16928#discussion_r846505369


##########
runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectTimerInternals.java:
##########
@@ -46,6 +52,11 @@ private DirectTimerInternals(
     this.processingTimeClock = clock;
     this.watermarks = watermarks;
     this.timerUpdateBuilder = timerUpdateBuilder;
+    this.modifiedTimers = Maps.newHashMap();

Review Comment:
   Nit: should this be an immutable map?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org