You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/11/02 22:44:59 UTC
[kudu-CR] fix compile error in ssl socket.cc on Ubuntu 16.04
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4921
to review the following change.
Change subject: fix compile error in ssl_socket.cc on Ubuntu 16.04
......................................................................
fix compile error in ssl_socket.cc on Ubuntu 16.04
X509_check_host() is defined in x509v3.h, not x509.h.
Change-Id: I0a80c6deea2d4116e37d9b034b69ac1870838077
---
M src/kudu/util/net/ssl_socket.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/4921/1
--
To view, visit http://gerrit.cloudera.org:8080/4921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a80c6deea2d4116e37d9b034b69ac1870838077
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fix compile error in ssl socket.cc on Ubuntu 16.04
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: fix compile error in ssl_socket.cc on Ubuntu 16.04
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a80c6deea2d4116e37d9b034b69ac1870838077
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] fix compile error in ssl socket.cc on Ubuntu 16.04
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: fix compile error in ssl_socket.cc on Ubuntu 16.04
......................................................................
fix compile error in ssl_socket.cc on Ubuntu 16.04
X509_check_host() is defined in x509v3.h, not x509.h.
Change-Id: I0a80c6deea2d4116e37d9b034b69ac1870838077
Reviewed-on: http://gerrit.cloudera.org:8080/4921
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/net/ssl_socket.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a80c6deea2d4116e37d9b034b69ac1870838077
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>