[GitHub] [ignite] NSAmelchev commented on a change in pull request #9195: IGNITE-14990 Incorrect values of cache, cache group, data region metrics after cluster re-activation

[GitBox <gi...@apache.org>]

NSAmelchev commented on a change in pull request #9195:
URL: https://github.com/apache/ignite/pull/9195#discussion_r659560806



##########
File path: modules/core/src/test/java/org/apache/ignite/internal/metric/CacheMetricsAddRemoveTest.java
##########
@@ -161,6 +200,9 @@ private void createCache(@Nullable String dataRegionName, @Nullable String cache
         if (cacheName != null)
             ccfg.setName(cacheName);
 
+        if (groupName != null)
+            ccfg.setGroupName(groupName);
+

Review comment:
       I think this class should be refactored. This is not related to the issue and should be done in a separate issue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org