You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/01 15:55:28 UTC
[GitHub] [iceberg] szehon-ho commented on a change in pull request #3640: Core: Support case sensitivity in MergingSnapshotProducer
szehon-ho commented on a change in pull request #3640:
URL: https://github.com/apache/iceberg/pull/3640#discussion_r760320426
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -125,6 +127,16 @@ public ThisT set(String property, String value) {
return self();
}
+ protected void caseSensitiveBinding(boolean newCaseSensitive) {
Review comment:
Other method argument is 'isCaseSensitive', should we follow?
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -125,6 +127,16 @@ public ThisT set(String property, String value) {
return self();
}
+ protected void caseSensitiveBinding(boolean newCaseSensitive) {
Review comment:
Also wondering, method clashing is why this method can not be just caseSensitive(isCaseSensitive)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org