You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "venkateshbalaji99 (via GitHub)" <gi...@apache.org> on 2023/05/17 11:13:09 UTC
[GitHub] [spark] venkateshbalaji99 opened a new pull request, #41199: Spark-43536 Fixing statsd sink reporter
venkateshbalaji99 opened a new pull request, #41199:
URL: https://github.com/apache/spark/pull/41199
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #41199: Spark-43536 Fixing statsd sink reporter
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #41199:
URL: https://github.com/apache/spark/pull/41199#issuecomment-1551416331
See https://spark.apache.org/contributing.html and please fix up this PR. Needs more explanation too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] venkateshbalaji99 commented on pull request #41199: [SPARK-43536][CORE] Fixing statsd sink reporter
Posted by "venkateshbalaji99 (via GitHub)" <gi...@apache.org>.
venkateshbalaji99 commented on PR #41199:
URL: https://github.com/apache/spark/pull/41199#issuecomment-1690283871
Hi @paymog , as you have pointed out, this seems to be an issue in flink too, where the metric value is not being decremented upon each push, while statsd expects it to. But the motivation behind not wanting to add a decrement logic here is because this system is more resilient towards intermittent failures (like some packets being lost), since the total value will still be retained, whereas in the case where we opt to send delta ourselves, these kind of error might start up adding up over time. Since gauge metrics match our use case fully, I think remapping the spark counter metrics to be interpreted as gauge by statsD would be the simplest solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] abmodi commented on pull request #41199: Spark-43536 Fixing statsd sink reporter
Posted by "abmodi (via GitHub)" <gi...@apache.org>.
abmodi commented on PR #41199:
URL: https://github.com/apache/spark/pull/41199#issuecomment-1561648001
@dongjoon-hyun could you please review this. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] paymog commented on pull request #41199: [SPARK-43536][CORE] Fixing statsd sink reporter
Posted by "paymog (via GitHub)" <gi...@apache.org>.
paymog commented on PR #41199:
URL: https://github.com/apache/spark/pull/41199#issuecomment-1688686712
I think this should actually be fixed in the statsd reporter. The [statsd spec](https://github.com/statsd/statsd/blob/master/docs/metric_types.md) says:
> At each flush the current count is sent and reset to 0.
However, looking at the [implementation](https://github.com/apache/flink/blob/master/flink-metrics/flink-metrics-statsd/src/main/java/org/apache/flink/metrics/statsd/StatsDReporter.java#L129-L131) of the statsd reporter, that spec doesn't seem to be followed. One possibility to fix upstream is to do something like the following:
```
private void reportCounter(final String name, final Counter counter) {
send(name, counter.getCount());
counter.dec(counter.getCount());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] venkateshbalaji99 closed pull request #41199: Spark-43536 Fixing statsd sink reporter
Posted by "venkateshbalaji99 (via GitHub)" <gi...@apache.org>.
venkateshbalaji99 closed pull request #41199: Spark-43536 Fixing statsd sink reporter
URL: https://github.com/apache/spark/pull/41199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] venkateshbalaji99 commented on pull request #41199: Spark-43536 Fixing statsd sink reporter
Posted by "venkateshbalaji99 (via GitHub)" <gi...@apache.org>.
venkateshbalaji99 commented on PR #41199:
URL: https://github.com/apache/spark/pull/41199#issuecomment-1551363611
retest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43536][CORE] Fixing statsd sink reporter [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #41199: [SPARK-43536][CORE] Fixing statsd sink reporter
URL: https://github.com/apache/spark/pull/41199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] venkateshbalaji99 commented on pull request #41199: [SPARK-43536][CORE] Fixing statsd sink reporter
Posted by "venkateshbalaji99 (via GitHub)" <gi...@apache.org>.
venkateshbalaji99 commented on PR #41199:
URL: https://github.com/apache/spark/pull/41199#issuecomment-1574926819
> Hi, @venkateshbalaji99 and @abmodi . This is a very old behavior since Apache Spark 2.3.0 (6 years). Could you elaborate which `count` metric did you have an issue specifically?
I primarily tested the recordsRead.count and recordsWritten.count metrics, but the behaviour was similar for other count metrics as well (runTime.count was also behaving similarly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] venkateshbalaji99 commented on pull request #41199: [SPARK-43536][CORE] Fixing statsd sink reporter
Posted by "venkateshbalaji99 (via GitHub)" <gi...@apache.org>.
venkateshbalaji99 commented on PR #41199:
URL: https://github.com/apache/spark/pull/41199#issuecomment-1690293963
Hi @dongjoon-hyun, can you please take another look if you have time? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43536][CORE] Fixing statsd sink reporter [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41199:
URL: https://github.com/apache/spark/pull/41199#issuecomment-1836950123
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org