[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #807: Netlink: broadcast the link status change to userspace

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #807: Netlink: broadcast the link status change to userspace
URL: https://github.com/apache/incubator-nuttx/pull/807#discussion_r409579024
 
 

 ##########
 File path: net/netlink/netlink_conn.c
 ##########
 @@ -317,7 +317,7 @@ void netlink_add_broadcast(int group, FAR struct netlink_response_s *data)
 
   while ((conn = netlink_nextconn(conn)) != NULL)
     {
-      if (conn->groups & (1 << (group - 1)) == 0)
+      if (!(conn->groups & (1 << (group - 1))))
 
 Review comment:
   We should try to be consistent with this.  I have change all of these to use (bitwise expression) == 0  instead of !(bitwise expression).  I reserve ! for use with boolean expressions.
   
   Doesn't matter technically and there is not preference in the coding standard, but it woudl be nice if we didn't keed change each other's code only to match our personal preference.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services