You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/08/02 14:37:20 UTC

[GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...

Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2109
  
    Just had a brief look. Looks nice. Actually, I like how you moved the file filter to the `FileInputFormat` instead of having it as a special case of the file monitoring source. 
    
    I think you made at least one API breaking change which we will have to revert on `StreamExecutionEnvironment` after the next release (1.1.0). I think nobody will use `GlobFilePathFilter` unless it is documented. Could you revert the method changes on the environment and add some documentation?
    
    I would keep the default filter as it is. A lot of users wouldn't expect the default filter to evaluate regular expressions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---