You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "zhangbutao (via GitHub)" <gi...@apache.org> on 2025/07/16 05:47:20 UTC

[PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

zhangbutao opened a new pull request, #5980:
URL: https://github.com/apache/hive/pull/5980

   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Unify the metastore-site.xml files for HMS Docker and HMS tar to ensure consistent default configurations when starting Standalone HMS.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Local build Standalone HMS tar and Standalone HMS docker images
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5980: HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar
URL: https://github.com/apache/hive/pull/5980


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker. Same thing there, output is redirected to System.out
   also could we put a note on that in the Readme
   
   maybe change the log dir to 
   - /var/log/hive/ 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker. Same thing there output is redirected to System.out



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker. Same thing there output is redirected to System.out
   also could we put a note on that in the Readme
   
   maybe change the log dir to 
   - /var/log/hive/ 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2594720031


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   Sorry for the late response(I've been on medical leave and I missed notifications during a crisis). I suppose Kubernetes is almost the only production-grade container orchestration tool. In the Kubernetes world, a main container typically outputs logs to stdout/stderr, a Kubernetes administrator sets up log collectors such as a Fluentd daemonset, the log collector transfers all containers' logs to a central system such as Elasticsearch, and some chores such as log rotations are handled by Kublet or something configured by a k8s administrator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209713876


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   Yes, i know what you mean.
   
   The `docker logs -f` command is quite convenient for simple testing and viewing logs. However, in a real production environment, users typically persist the metastore logs locally for better log management. 
   
   After this PR, log4j defaults to storing HMS logs in /tmp/hive/metastore.log. If users want to view the logs on the local host machine, they can mount the HMS logs to a local directory when starting the HMS Docker container. For example, using the command:
   
   `docker run -itd --name='hivehms' -v /data/hmslog:/tmp/hive apache/hive:standalone-metastore-4.1.0`
   
   Then, users can check the HMS logs in the local directory at `/data/hmslog/metastore.log`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2601580464


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   For instance, Google Kubernetes Engine can send stdout/stderr to Google Cloud Logging without additional configurations. I suppose it is [a typical logging practice with k8s](https://kubernetes.io/docs/concepts/cluster-administration/logging/) and can be the default choice of HMS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209396237


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   @zhangbutao, please check the logger output with docker conf log4j2 properties and the metastore one. If you tail the container logs, you'll notice that most of the logging is gone. 



##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   @zhangbutao, please check the logger output with docker conf log4j2 properties and the metastore one. 
   If you tail the container logs, you'll notice that most of the logging is gone. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209752413


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   Additionally, if users want to modify the `metastore-log4j2.properties` file before starting the HMS Docker, they can also use the local mount method. That is, they can use a local `metastore-log4j2.properties` file when starting the HMS Docker. This allows users to flexibly modify the `metastore-log4j2.properties`, such as changing the HMS log level or outputting logs to `stdout`.
   
   `docker run -itd --name='hive420hms_stdout' -v /data/hmsdocker/conf:/opt/hive/conf apache/hive:standalone-metastore-4.1.0`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker. Same thing there output is redirected to System.out
   also could we put a note on that in the Readme
   
   maybe change the log dir to `/var/hive/log/metastore.log` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker. Same thing there, output is redirected to System.out
   
   - Could we put a note on that in the Readme
   - Maybe consider changing the log dir to `/var/log/hive/ `
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2594720031


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   Sorry for the late response. I suppose Kubernetes is almost the only production-grade container orchestration tool. In the Kubernetes world, a main container typically outputs logs to stdout/stderr, a Kubernetes administrator sets up log collectors such as a Fluentd daemonset, the log collector transfers all containers' logs to a central system such as Elasticsearch, and some chores such as log rotations are handled by Kublet or something configured by a k8s administrator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2595803531


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   IMO, whether logs are output to a local directory or to stdout/stderr does not affect log collection in Kubernetes. We have many services (such as StarRocks/Doris) running on Kubernetes, and these services output logs to local directories, which are eventually collected by components like Elasticsearch and persisted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5980:
URL: https://github.com/apache/hive/pull/5980#issuecomment-4264445179

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker. Same thing there output is redirected to System.out
   also could we put a note on that in the Readme



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209812119


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   Hive docker log was changed by https://github.com/apache/hive/pull/5638.
   @okumin Any thought if we change it back?
   
   
   > maybe change the log dir to /var/hive/log/metastore.log ?
   
   Yes, The log dir can be changed by when `export HADOOP_CLIENT_OPTS`
   https://github.com/apache/hive/blob/5512ffda602bef605ad144f9040676149cc2c960/standalone-metastore/packaging/src/docker/entrypoint.sh#L48
   
   ```
   -export HADOOP_CLIENT_OPTS="$HADOOP_CLIENT_OPTS -Xmx1G $SERVICE_OPTS"
   +export HADOOP_CLIENT_OPTS="$HADOOP_CLIENT_OPTS -Xmx1G -Dmetastore.log.dir=/var/hive/log -Dmetastore.log.file=metastore.log $SERVICE_OPTS"
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker. Same thing there, output is redirected to System.out
   
   - Could we put a note on that in the Readme
   - Maybe consider changing the log dir to 
   - /var/log/hive/ 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2306940985


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   hi @okumin, do you agree with the above suggestion?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2230666123


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   okumin might be on vacation, let's wait a bit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209752413


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   Additionally, if users want to modify the `metastore-log4j2.properties` file before starting the HMS Docker, they can also use the local mount method. That is, they can use a local `metastore-log4j2.properties` file when starting the HMS Docker. This allows users to flexibly modify the `metastore-log4j2.properties`, such as changing the HMS log level or outputting logs to `stdout`.
   
   ```
   ls /data/hmsdocker/conf
   
   metastore-log4j2.properties
   metastore-site.xml
   ```
   
   `docker run -itd --name='hive420hms_stdout' -v /data/hmsdocker/conf:/opt/hive/conf apache/hive:standalone-metastore-4.1.0`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker. Same thing there output is redirected to System.out
   also could we put a note on that in the Readme
   
   maybe change the log dir to 
   - /var/log/hiveserver2 
   - /var/log/metastore
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5980:
URL: https://github.com/apache/hive/pull/5980#discussion_r2209761725


##########
standalone-metastore/packaging/src/docker/Dockerfile:
##########
@@ -67,15 +67,13 @@ ENV HADOOP_HOME=/opt/hadoop \
 ENV PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH
 
 COPY entrypoint.sh /
-COPY conf $HIVE_HOME/conf

Review Comment:
   ok, then we should probably make it consistent with Hive docker. Same thing there, output is redirected to System.out
   
   - Could we include details about logging in the README?
   - Maybe consider changing the log dir to `/var/log/hive/ `
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5980:
URL: https://github.com/apache/hive/pull/5980#issuecomment-3077147031

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5980) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [1521 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5980&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5980&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5980&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5980&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [1.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5980&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5980)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

Re: [PR] HIVE-29094: Unifying the metastore-site.xml File for HMS Docker and HMS tar [hive]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5980:
URL: https://github.com/apache/hive/pull/5980#issuecomment-3865858231

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org