[GitHub] [trafficcontrol] rob05c commented on issue #3500: Fix Traffic Ops Delivery Service Update of Old Versions to Omit New Fields

[GitBox <gi...@apache.org>]

rob05c commented on issue #3500: Fix Traffic Ops Delivery Service Update of Old Versions to Omit New Fields
URL: https://github.com/apache/trafficcontrol/pull/3500#issuecomment-485879522
 
 
   > why not just change the "sanitize" process to just read what's in the database already
   
   We could. That would be much, much slower, to incur another DB round-trip to load all the data unnecessarily. A DB roundtrip is at least 50ms, maybe more in a production environment, where the reflection is likely <2ms.
   
   I'm not a fan of reflection, but this was a relatively small function, and we're already doing it in the CRUDer framework; and the `sqlx` calls all have a huge amount of it, it's just hidden from us. And it's by-far the most performant option (unless we did some very ugly things in the code).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services