You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maedhroz (via GitHub)" <gi...@apache.org> on 2025/02/21 00:00:40 UTC
Re: [PR] CASSANDRA-20323 Avoid limit on RFP fetch in the case of an unresolved static row [cassandra]
maedhroz commented on code in PR #3916:
URL: https://github.com/apache/cassandra/pull/3916#discussion_r1964529742
##########
test/distributed/org/apache/cassandra/distributed/test/ReplicaFilteringProtectionTest.java:
##########
@@ -72,24 +71,6 @@ public static void teardown()
cluster.close();
}
- @Test
- public void testMissingStaticRowWithNonStaticExpression()
- {
- cluster.schemaChange(withKeyspace("CREATE TABLE %s.single_predicate (pk0 int, ck0 int, ck1 int, s0 int static, s1 int static, v0 int, PRIMARY KEY (pk0, ck0, ck1)) " +
- "WITH CLUSTERING ORDER BY (ck0 ASC, ck1 DESC) AND read_repair = 'NONE'"));
-
- cluster.get(1).executeInternal(withKeyspace("INSERT INTO %s.single_predicate (pk0, ck0, ck1, s0, s1, v0) " +
- "VALUES (0, 1, 2, 3, 4, 5) USING TIMESTAMP 1"));
- cluster.get(2).executeInternal(withKeyspace("UPDATE %s.single_predicate USING TIMESTAMP 2 SET s0 = 6, s1 = 7, v0 = 8 " +
- "WHERE pk0 = 0 AND ck0 = 9 AND ck1 = 10"));
-
- // Node 2 will not produce a match for the static row. Make sure that replica filtering protection does not
- // fetch the entire partition, which could let non-matching rows slip through combined with the fact that we
- // don't post-filter at the coordinator with no regular column predicates in the query.
- String select = withKeyspace("SELECT pk0, ck0, ck1, s0, s1 FROM %s.single_predicate WHERE ck1 = 2 ALLOW FILTERING");
- assertRows(cluster.coordinator(1).execute(select, ConsistencyLevel.ALL), row(0, 1, 2, 6, 7));
- }
-
Review Comment:
Moved to `ReplicaFilteringWithStaticsTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org