You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Johnny-Liao <gi...@git.apache.org> on 2017/07/25 06:38:20 UTC
[GitHub] thrift pull request #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThrea...
GitHub user Johnny-Liao opened a pull request:
https://github.com/apache/thrift/pull/1313
THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSelectorServer model.
Such as the title. More information see : https://issues.apache.org/jira/browse/THRIFT-4251
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Johnny-Liao/thrift THRIFT-4251
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1313
----
commit 4dc1eb98e4b750a25ba0ed64c207fd64f24a7f31
Author: Johnny-Liao <10...@qq.com>
Date: 2017-07-25T06:23:28Z
THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSelectorServer model.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1313
However, as with all the other issues, they were already resolved, so the fact you are still seeing this with a recent kernel and java version means there's still a bug that needs to be fixed somewhere. There shouldn't be a workaround in every Java program that uses a Selector(). I would still encourage you to come up with a simple example that demonstrates it without Thrift involved and report it upstream.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1313
It means nobody replied to my requests for comments, so I assumed nobody
has an issue or nobody cares; whatever the case, I committed it to the
project. :)
On Thu, Sep 21, 2017 at 9:33 PM, xiaohu-zhang <no...@github.com>
wrote:
> MY english is poor. could you please explain what is the it's been
> crickets mean ? thank you very much!
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/thrift/pull/1313#issuecomment-331325983>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ALOdbQESIjeimaSz2AGiRW8KU8nn7Zzhks5skw5ngaJpZM4OiH7s>
> .
>
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by xiaohu-zhang <gi...@git.apache.org>.
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/thrift/pull/1313
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1313
So I asked on the mailing list and it's been crickets, so I'm going to merge this. It passed all the tests.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by Johnny-Liao <gi...@git.apache.org>.
Github user Johnny-Liao commented on the issue:
https://github.com/apache/thrift/pull/1313
My linux kernel is 3.10.0 when this bug occured. And I'm pretty sure that still trouble many people who dependence Thrift to implements theirs server program. Netty uses this approach to mask the underlying problem and why can't we.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by xiaohu-zhang <gi...@git.apache.org>.
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/thrift/pull/1313
MY english is poor. could you please explain what is the it's been crickets mean ? thank you very much!
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by Johnny-Liao <gi...@git.apache.org>.
Github user Johnny-Liao commented on the issue:
https://github.com/apache/thrift/pull/1313
It's not elegant way to rebuild Selector in every Java program, but it's a effective way to fix this bug. And so many year passed it not really fixed in JDK or kernel. This is one reason for some Frameworks implemented this solution. After all, the consequences of this bug are too serious.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by Johnny-Liao <gi...@git.apache.org>.
Github user Johnny-Liao commented on the issue:
https://github.com/apache/thrift/pull/1313
I found a report maybe more relevant with this issue.
See : [http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933](http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933)
It gives a solution what is creates a new Selector to replace the old one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by xiaohu-zhang <gi...@git.apache.org>.
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/thrift/pull/1313
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933
it sounds like have been resolved yet in jdk7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1313
According to the documentation of the defect that triggered this (http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6670302), it indicates this only occurs in kernel 2.4 series, and if you move to kernel 2.6 this issue goes away. Given this is an operating system defect, I'm inclined to recommend we do not merge this and resolve it as won't fix, because it isn't a defect in Thrift or in Java, but rather in the operating system it is running on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by xiaohu-zhang <gi...@git.apache.org>.
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/thrift/pull/1313
Thank you ! honestly speaking , netty and lots of framework implementing this fix. I also doubt
It is useful in jdk7. I agree with you ,But if I was you , I will not change the original code,unless give
the unit test to prove it happend in jdk7
---
[GitHub] thrift pull request #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThrea...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1313
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1313
There are conflicting reports to what the root cause of this issue really is. I found:
http://bugs.java.com/view_bug.do?bug_id=6693490 fixed in Java 7b55
http://bugs.java.com/view_bug.do?bug_id=6897993 possibly caused by above, fixed in Java 7b77
http://bugs.java.com/view_bug.do?bug_id=6670302 bug in linux 2.4 kernel fixed in 2.6
Given you reproduced it under Java 8b131 then it sounds like it would be a different issue to what's already been reported, or a regression in one of them. Folks seem to think this issue was resolved. I actually found a number of projects that implemented their own solution, but they were all slightly different.
Have you looked into reopening 6670302 with a sample program that recreates it under Java 8b131? Or, does the sample app used in that defect reproduce on your system possibly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1313
I'd like additional feedback from folks who use Thrift with Java on this. It seems like the wrong place to fix the issue, but it sounds like many projects are implementing their own fix for it. I've never seen it happen.
---