[jira] [Resolved] (CALCITE-3357) Trivial null checking in RelSet#addAbstractConverters

["Haisheng Yuan (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Haisheng Yuan resolved CALCITE-3357.
------------------------------------
    Fix Version/s: 1.22.0
       Resolution: Fixed

Fixed in https://github.com/apache/calcite/commit/3b26283b61ca5e6be79c8e95c6558c8ab6985952.

> Trivial null checking in RelSet#addAbstractConverters
> -----------------------------------------------------
>
>                 Key: CALCITE-3357
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3357
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: jin xing
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In current code of *RelSet#addAbstractConverters*, null checking of *curRelTrait* happens after clause of assert *curRelTrait.getTraitDef() == traitDef*;
> It makes more sense to adjust the order;
> In my understanding, this issue was not found previously for two reasons:
>  # AbstractConverter is not enabled by default ([https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableConvention.java#L65])
>  # It rarely happens that two algebra expression operators have identical semantics but different *RelTraitDef*
> I found this issue when working on https://issues.apache.org/jira/browse/CALCITE-2970



--
This message was sent by Atlassian Jira
(v8.3.4#803005)