You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Yates (JIRA)" <ji...@apache.org> on 2012/06/30 18:30:46 UTC
[jira] [Created] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Jesse Yates created HBASE-6296:
----------------------------------
Summary: Refactor EventType to track its own ExecutorService type
Key: HBASE-6296
URL: https://issues.apache.org/jira/browse/HBASE-6296
Project: HBase
Issue Type: Improvement
Components: master
Affects Versions: 0.96.0
Reporter: Jesse Yates
Priority: Minor
Fix For: 0.96.0
Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6296:
-------------------------
Status: Open (was: Patch Available)
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6296:
-------------------------
Attachment: 6296v1.txt
Retry
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404642#comment-13404642 ]
Hadoop QA commented on HBASE-6296:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534127/6296v1.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2305//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2305//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2305//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2305//console
This message is automatically generated.
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6296:
-------------------------------
Status: Patch Available (was: Open)
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6296:
-------------------------------
Status: Open (was: Patch Available)
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6296:
-------------------------
Status: Patch Available (was: Open)
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6296:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. I ran tests locally w/ this patch applied and no failures or errors. Thanks for the clean up Jesse.
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6296:
-------------------------------
Attachment: java_hbase-6296-v0.patch
Attaching simple version.
Causes a slight overhead increase (a handful of pointers), but makes the code much more managable. Alternatively, could just move the switch from ExecutorService into the method in EventHandler, but that would loose all the nice OO going on in the current patch.
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404659#comment-13404659 ]
Lars Hofhansl commented on HBASE-6296:
--------------------------------------
+1 on v1
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6296:
-------------------------------
Attachment: java_hbase-6296-v0.patch
Oops, lets try this version.
(To answer HadoopQA, no tests were be changed because this should be all under the covers and just work - impl details).
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404640#comment-13404640 ]
Jesse Yates commented on HBASE-6296:
------------------------------------
@stack: +1 looks good to me. thanks!
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6296:
-------------------------
Status: Open (was: Patch Available)
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6296:
-------------------------
Attachment: 6296v1.txt
Minor change to make spacing consistent and made a method package private rather than public. This ok w/ you Jesse?
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404588#comment-13404588 ]
Hadoop QA commented on HBASE-6296:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534115/java_hbase-6296-v0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2303//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2303//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2303//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2303//console
This message is automatically generated.
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6296:
-------------------------
Status: Patch Available (was: Open)
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates reassigned HBASE-6296:
----------------------------------
Assignee: Jesse Yates
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Jesse Yates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Yates updated HBASE-6296:
-------------------------------
Release Note: Simple refactor of ExecutorType to bind more tightly to the EventType (rather than keeping them across different files).
Status: Patch Available (was: Open)
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6296) Refactor EventType to track its own
ExecutorService type
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404559#comment-13404559 ]
Hadoop QA commented on HBASE-6296:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534114/java_hbase-6296-v0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2302//console
This message is automatically generated.
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira