You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/10 10:58:38 UTC
[GitHub] [druid] agricenko opened a new pull request #10016: Integration test docker compose readme
agricenko opened a new pull request #10016:
URL: https://github.com/apache/druid/pull/10016
Readme updates
Added "docker compose" section
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm commented on a change in pull request #10016: Integration test docker compose readme
Posted by GitBox <gi...@apache.org>.
maytasm commented on a change in pull request #10016:
URL: https://github.com/apache/druid/pull/10016#discussion_r439687666
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
+
+docker-compose.yml - Defining minimal Druid cluster that can be used for non cluster tests.
+
+ docker-compose -f docker-compose.yml up
+ DRUID_INTEGRATION_TEST_GROUP=query docker-compose -f docker-compose.yml up
+
+docker-compose.override-env.yml - the same configuration as docker-compose.yml + override-env variable that needed to run cloud tests
+
+ OVERRIDE_ENV=./environment-configs/override-examples/s3 docker-compose -f docker-compose.override-env.yml up
+
+docker-compose.druid-hadoop.yml - druid hadoop
Review comment:
"druid hadoop" is very vague. Can you change to something like "for starting Apache Hadoop 2.8.5 cluster with the same setup as the Druid tutorial".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] agricenko commented on a change in pull request #10016: Integration test docker compose readme
Posted by GitBox <gi...@apache.org>.
agricenko commented on a change in pull request #10016:
URL: https://github.com/apache/druid/pull/10016#discussion_r440046582
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
+
+docker-compose.yml - Defining minimal Druid cluster that can be used for non cluster tests.
+
+ docker-compose -f docker-compose.yml up
+ DRUID_INTEGRATION_TEST_GROUP=query docker-compose -f docker-compose.yml up
+
+docker-compose.override-env.yml - the same configuration as docker-compose.yml + override-env variable that needed to run cloud tests
Review comment:
Added some details
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
+
+docker-compose.yml - Defining minimal Druid cluster that can be used for non cluster tests.
+
+ docker-compose -f docker-compose.yml up
+ DRUID_INTEGRATION_TEST_GROUP=query docker-compose -f docker-compose.yml up
+
+docker-compose.override-env.yml - the same configuration as docker-compose.yml + override-env variable that needed to run cloud tests
+
+ OVERRIDE_ENV=./environment-configs/override-examples/s3 docker-compose -f docker-compose.override-env.yml up
+
+docker-compose.druid-hadoop.yml - druid hadoop
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm commented on a change in pull request #10016: Integration test docker compose readme
Posted by GitBox <gi...@apache.org>.
maytasm commented on a change in pull request #10016:
URL: https://github.com/apache/druid/pull/10016#discussion_r439688090
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
+
+docker-compose.yml - Defining minimal Druid cluster that can be used for non cluster tests.
+
+ docker-compose -f docker-compose.yml up
+ DRUID_INTEGRATION_TEST_GROUP=query docker-compose -f docker-compose.yml up
+
+docker-compose.override-env.yml - the same configuration as docker-compose.yml + override-env variable that needed to run cloud tests
Review comment:
Maybe add that override-env variable is for file containing Druid property for override default values or something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm commented on a change in pull request #10016: Integration test docker compose readme
Posted by GitBox <gi...@apache.org>.
maytasm commented on a change in pull request #10016:
URL: https://github.com/apache/druid/pull/10016#discussion_r439688171
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
Review comment:
defining -> defines
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
+
+docker-compose.yml - Defining minimal Druid cluster that can be used for non cluster tests.
Review comment:
defining -> defines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] agricenko commented on a change in pull request #10016: Integration test docker compose readme
Posted by GitBox <gi...@apache.org>.
agricenko commented on a change in pull request #10016:
URL: https://github.com/apache/druid/pull/10016#discussion_r440048021
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
+
+docker-compose.yml - Defining minimal Druid cluster that can be used for non cluster tests.
+
+ docker-compose -f docker-compose.yml up
+ DRUID_INTEGRATION_TEST_GROUP=query docker-compose -f docker-compose.yml up
Review comment:
Added some details.
2nd docker-compose need to be used for security/query tests. Druid docker container update keys in druid.sh if DRUID_INTEGRATION_TEST_GROUP="query" or "security"
druid/integration-tests/docker/druid.sh:85
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] agricenko commented on a change in pull request #10016: Integration test docker compose readme
Posted by GitBox <gi...@apache.org>.
agricenko commented on a change in pull request #10016:
URL: https://github.com/apache/druid/pull/10016#discussion_r440046254
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
+
+docker-compose.yml - Defining minimal Druid cluster that can be used for non cluster tests.
Review comment:
Fixed
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm merged pull request #10016: Integration test docker compose readme
Posted by GitBox <gi...@apache.org>.
maytasm merged pull request #10016:
URL: https://github.com/apache/druid/pull/10016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm commented on a change in pull request #10016: Integration test docker compose readme
Posted by GitBox <gi...@apache.org>.
maytasm commented on a change in pull request #10016:
URL: https://github.com/apache/druid/pull/10016#discussion_r439688115
##########
File path: integration-tests/README.md
##########
@@ -68,6 +68,25 @@ can either be 8 or 11.
Druid's configuration (using Docker) can be overrided by providing -Doverride.config.path=<PATH_TO_FILE>.
The file must contain one property per line, the key must start with `druid_` and the format should be snake case.
+## Docker compose
+
+Docker compose yamls located in "docker" folder
+
+docker-compose.base.yml - Base file that defining all containers for integration test
+
+docker-compose.yml - Defining minimal Druid cluster that can be used for non cluster tests.
+
+ docker-compose -f docker-compose.yml up
+ DRUID_INTEGRATION_TEST_GROUP=query docker-compose -f docker-compose.yml up
Review comment:
Can you add what is the different between line 79 and line 80?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org