You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by Jean-Baptiste Quenot <jb...@apache.org> on 2007/03/08 10:50:40 UTC

Backporting nested forms (Was: Re: svn commit: r515729 - /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/html/form/Form.java)

* knopp@apache.org:
> Author: knopp
> Date: Wed Mar  7 12:03:08 2007
> New Revision: 515729
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=515729
> Log:
> Nested forms support
> 
> Modified:
>     incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/html/form/Form.java

Hi Matej,

Thanks for backporting this.  Can  we consider that Form is synced
now  between trunk  and 1.x?   I noticed  still some  differences,
like:

* Javadoc stating nested forms
* HIDDEN_FIELD_FAKE_SUBMIT and such
* getDefaultButton() checks isRootForm() in trunk
* onComponentTagBody()

May I kindly request you to review the changes, or otherwise state
that the  differences are minor so  we can remove class  Form from
[1]the list of things to backport from trunk.

Thanks a lot,
-- 
     Jean-Baptiste Quenot
aka  John Banana   Qwerty
http://caraldi.com/jbq/

[1] http://cwiki.apache.org/confluence/display/WICKET/To+Sync+Between+Branches

Re: Backporting nested forms (Was: Re: svn commit: r515729 - /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/html/form/Form.java)

Posted by Jean-Baptiste Quenot <jb...@apache.org>.

* Matej Knopp:

> Thanks for pointing  that out. I've added the  javadoc and fixed
> set/getDefaultButton.
>
> However, the  HIDDEN_FIELD_FAKE_SUBMIT is not related  to nested
> forms.
>
> Anyway, i'd say the form can be removed from the list.

Thanks a lot!  It's very good if every developer can add things to
backport in that  page, and take care of backporting  at least one
of the things listed and update  the list accordingly.  As I'm new
to the  project, I  don't always  know what  is good  to backport,
what isn't,  what should  be backported  and what  shouldn't.  And
especially when I do it myself,  I need to check the full revision
log on  every branch to  understand what changes went  where, why,
and by whom.  Did I mention it sucks a lot of time?
-- 
     Jean-Baptiste Quenot
aka  John Banana   Qwerty
http://caraldi.com/jbq/

Re: Backporting nested forms (Was: Re: svn commit: r515729 - /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/html/form/Form.java)

Posted by Matej Knopp <ma...@knopp.sk>.

Thanks for pointing that out. I've added the javadoc and fixed 
set/getDefaultButton.

However, the HIDDEN_FIELD_FAKE_SUBMIT is not related to nested forms.

Anyway, i'd say the form can be removed from the list.

-Matej

Jean-Baptiste Quenot wrote:
> * knopp@apache.org:
>> Author: knopp
>> Date: Wed Mar  7 12:03:08 2007
>> New Revision: 515729
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=515729
>> Log:
>> Nested forms support
>>
>> Modified:
>>     incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/html/form/Form.java
> 
> Hi Matej,
> 
> Thanks for backporting this.  Can  we consider that Form is synced
> now  between trunk  and 1.x?   I noticed  still some  differences,
> like:
> 
> * Javadoc stating nested forms
> * HIDDEN_FIELD_FAKE_SUBMIT and such
> * getDefaultButton() checks isRootForm() in trunk
> * onComponentTagBody()
> 
> May I kindly request you to review the changes, or otherwise state
> that the  differences are minor so  we can remove class  Form from
> [1]the list of things to backport from trunk.
> 
> Thanks a lot,