You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/04/05 00:49:07 UTC

Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66466/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Repository: mesos


Description
-------

Updated `RESERVE()` helper to allow specifying an operation ID.


Diffs
-----

  src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 


Diff: https://reviews.apache.org/r/66466/diff/1/


Testing
-------

`sudo bin/mesos-tests` on GNU/Linux

The tests added by https://reviews.apache.org/r/66468/ use this helper with an `OperationID`.


Thanks,

Gaston Kleiman


Re: Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID.

Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66466/
-----------------------------------------------------------

(Updated April 20, 2018, 3:54 p.m.)


Review request for mesos and Greg Mann.


Changes
-------

Rebased.


Bugs: MESOS-8191
    https://issues.apache.org/jira/browse/MESOS-8191


Repository: mesos


Description
-------

Updated `RESERVE()` helper to allow specifying an operation ID.


Diffs (updated)
-----

  src/tests/mesos.hpp 7356523a2a37858bbe866527425f35502ff5ad82 


Diff: https://reviews.apache.org/r/66466/diff/2/

Changes: https://reviews.apache.org/r/66466/diff/1-2/


Testing
-------

`sudo bin/mesos-tests` on GNU/Linux

The tests added by https://reviews.apache.org/r/66468/ use this helper with an `OperationID`.


Thanks,

Gaston Kleiman


Re: Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66466/#review200849
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On April 5, 2018, 12:49 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66466/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 12:49 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `RESERVE()` helper to allow specifying an operation ID.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 
> 
> 
> Diff: https://reviews.apache.org/r/66466/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> The tests added by https://reviews.apache.org/r/66468/ use this helper with an `OperationID`.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>