[GitHub] [geode] kirklund commented on a diff in pull request #7569: GEODE-10222: Handle null memberID in GII

[GitBox <gi...@apache.org>]

kirklund commented on code in PR #7569:
URL: https://github.com/apache/geode/pull/7569#discussion_r845444917


##########
geode-core/src/main/java/org/apache/geode/internal/cache/versions/DiskVersionTag.java:
##########
@@ -44,7 +44,7 @@ public void setMemberID(DiskStoreID memberID) {
   @Override
   public void replaceNullIDs(VersionSource memberID) {
     if (getMemberID() == null) {
-      throw new AssertionError("Member id should not be null for persistent version tags");
+      throw new IllegalStateException("Member id should not be null for persistent version tags");

Review Comment:
   Would `NullMemberIdException` extend `IllegalStateException`? We need to be concerned with how the call-path handles any runtime exceptions that are thrown. It's easy to ensure that internal-only checked exceptions don't make it to the User but runtime exceptions can easily slip through. Would you make it a new external visible User exception?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org