You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by acton393 <gi...@git.apache.org> on 2017/11/16 07:38:13 UTC

[GitHub] incubator-weex pull request #872: bugfix appear event will fire wrongly whil...

GitHub user acton393 opened a pull request:

    https://github.com/apache/incubator-weex/pull/872

    bugfix appear event will fire wrongly while the view has not been loaded

    if the view has not been loaded or has not been added to its scroller view, it should not be
    notified appear event, because it cannot scroll to appear area as the scrollview scroll.
    
    Bug:102
    
    you can try this case http://dotwe.org/vue/26c9717b1c60304668899b996ac8a9ac

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/acton393/incubator-weex iOS-bugfix-waterfall-appearevent

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/872.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #872
    
----
commit f77f9cc35adc53c527853f898589fe6418ed4781
Author: acton393 <zh...@gmail.com>
Date:   2017-11-16T07:33:17Z

    [WEEX-102][iOS]bugfix appear event will fire wrongly while the view has not been loaded
    
     if the view has not been loaded or has not been added to its scroller view, it should not be
    notified appear event, because it cannot scroll to  appear area as the scrollview scroll.
    
    Bug:102

commit 539c71a13fce45dee933b8cc73beb5265ad33727
Author: acton393 <zh...@gmail.com>
Date:   2017-11-16T07:37:07Z

    [WEEX-102][iOS] bug-fix default config center return value
    
     if config center can not  find any config key value , it should
    return default value but just nil value.
    
    Bug: 102

----


---

[GitHub] incubator-weex pull request #872: [WEEX-102][iOS]bugfix appear event will fi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/872


---

[GitHub] incubator-weex issue #872: [WEEX-102][iOS]bugfix appear event will fire wron...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/872
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---