[GitHub] [incubator-inlong] shink commented on a change in pull request #2652: [INLONG-2643][k8s] update the configuration for helm chart

[GitBox <gi...@apache.org>]

shink commented on a change in pull request #2652:
URL: https://github.com/apache/incubator-inlong/pull/2652#discussion_r811645230



##########
File path: docker/kubernetes/templates/mysql-pvc.yaml
##########
@@ -15,22 +15,21 @@
 # limitations under the License.
 #
 
-{{- if and .Values.mysql.enabled .Values.mysql.persistentVolumeClaim.enabled }}
+{{- if not .Values.external.mysql.enabled }}
+{{- if .Values.volumes.persistence }}

Review comment:
       Is this style better?
   
   ```suggestion
   {{- if and (not .Values.external.mysql.enabled) .Values.volumes.persistence }}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org