[GitHub] [iceberg] pan3793 commented on a diff in pull request #7153: Spark: Support loading function as FunctionCatalog in SparkSessionCatalog

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #7153:
URL: https://github.com/apache/iceberg/pull/7153#discussion_r1147105234


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java:
##########
@@ -50,8 +53,8 @@
  *
  * @param <T> CatalogPlugin class to avoid casting to TableCatalog and SupportsNamespaces.
  */
-public class SparkSessionCatalog<T extends TableCatalog & SupportsNamespaces> extends BaseCatalog
-    implements CatalogExtension {
+public class SparkSessionCatalog<T extends TableCatalog & FunctionCatalog & SupportsNamespaces>

Review Comment:
   Guard is required in `setDelegateCatalog`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org