You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@httpd.apache.org by Cliff Woolley <cl...@yahoo.com> on 2001/12/24 07:51:57 UTC
getting t/SMOKE to work
So I decided to try out this mysterious t/SMOKE thing (well, mysterious to
those of us who haven't managed to keep up on our email for the last few
weeks)... and I got all kinds of compile errors. Anybody know why I'd
have to do the following in order to get the thing to run? t/TEST works
fine both with and without the changes.
Thanks,
Cliff
Index: Apache-Test/lib/Apache/TestConfig.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.117
diff -u -d -r1.117 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm 2001/12/21 12:44:16 1.117
+++ Apache-Test/lib/Apache/TestConfig.pm 2001/12/24 06:47:15
@@ -941,7 +941,7 @@
(my $generated = $file) =~ s/\.in$//;
push @extra_conf, $generated;
- debug "Including $generated config file";
+ debug("Including $generated config file");
next if -e $generated
&& -M $generated < -M $file;
@@ -977,7 +977,7 @@
return 1;
}
- error "cannot locate '$openssl' program required to generate SSL CA";
+ error("cannot locate '$openssl' program required to generate SSL CA");
exit(1);
}
Index: Apache-Test/lib/Apache/TestConfigPerl.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigPerl.pm,v
retrieving revision 1.43
diff -u -d -r1.43 TestConfigPerl.pm
--- Apache-Test/lib/Apache/TestConfigPerl.pm 2001/12/20 03:51:11 1.43
+++ Apache-Test/lib/Apache/TestConfigPerl.pm 2001/12/24 06:47:15
@@ -368,7 +368,7 @@
}
}
else {
- error "cannot open $file: $!";
+ error("cannot open $file: $!");
}
}
Index: Apache-Test/lib/Apache/TestServer.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestServer.pm,v
retrieving revision 1.46
diff -u -d -r1.46 TestServer.pm
--- Apache-Test/lib/Apache/TestServer.pm 2001/12/20 17:30:54 1.46
+++ Apache-Test/lib/Apache/TestServer.pm 2001/12/24 06:47:15
@@ -216,9 +216,9 @@
$opts->{debugger} ||= $ENV{MP_DEBUGGER} || 'gdb';
unless ($debuggers{ $opts->{debugger} }) {
- error "$opts->{debugger} is not a supported debugger",
+ error("$opts->{debugger} is not a supported debugger",
"These are the supported debuggers: ".
- join ", ", sort keys %debuggers;
+ join ", ", sort keys %debuggers);
die("\n");
}
@@ -311,7 +311,7 @@
if ($pid = $self->pid and !$tried_kill++) {
if (kill TERM => $pid) {
- warning "server $self->{name} shutdown";
+ warning("server $self->{name} shutdown");
sleep 1;
for (1..4) {
@@ -320,7 +320,7 @@
last;
}
if ($_ == 1) {
- warning "port $port still in use...";
+ warning("port $port still in use...");
}
else {
print "...";
@@ -329,28 +329,28 @@
}
if ($self->ping) {
- error "\nserver was shutdown but port $port ".
+ error("\nserver was shutdown but port $port ".
"is still in use, please shutdown the service ".
"using this port or select another port ".
- "for the tests";
+ "for the tests");
}
else {
print "done\n";
}
}
else {
- error "kill $pid failed: $!";
+ error("kill $pid failed: $!");
}
}
else {
- error "port $port is in use, ".
- "cannot determine server pid to shutdown";
+ error("port $port is in use, ".
+ "cannot determine server pid to shutdown");
return -1;
}
if (--$tries <= 0) {
- error "cannot shutdown server on Port $port, ".
- "please shutdown manually";
+ error("cannot shutdown server on Port $port, ".
+ "please shutdown manually");
return -1;
}
}
@@ -378,7 +378,7 @@
my $log_file_info = -e $log ?
"please examine $rlog" :
"$rlog wasn't created, start the server in the debug mode";
- error "@_ ($log_file_info)";
+ error("@_ ($log_file_info)");
}
sub start {
@@ -397,7 +397,7 @@
unless (-x $httpd) {
my $why = -e $httpd ? "is not executable" : "does not exist";
- error "cannot start server: httpd ($httpd) $why";
+ error("cannot start server: httpd ($httpd) $why");
return 0;
}
@@ -422,7 +422,7 @@
}
while ($old_pid and $old_pid == $self->pid) {
- warning "old pid file ($old_pid) still exists";
+ warning("old pid file ($old_pid) still exists");
sleep 1;
}
--------------------------------------------------------------
Cliff Woolley
cliffwoolley@yahoo.com
Charlottesville, VA
Re: getting t/SMOKE to work
Posted by Stas Bekman <st...@stason.org>.
Cliff Woolley wrote:
> So I decided to try out this mysterious t/SMOKE thing (well, mysterious to
> those of us who haven't managed to keep up on our email for the last few
> weeks)... and I got all kinds of compile errors. Anybody know why I'd
> have to do the following in order to get the thing to run? t/TEST works
> fine both with and without the changes.
The recent introduction of Apache::TestConfig::COLOR created an internal
circular dependency between Apache::TestTrace and Apache::TestConfig :(
The modules require each other. I think it's fixed now.
Doug, how about moving Apache::TestConfig::COLOR into
Apache::TestTrace::COLOR and thus killing this dependency.
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:stas@stason.org http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/