You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Shazron Abdullah (JIRA)" <ji...@apache.org> on 2015/02/13 03:08:12 UTC
[jira] [Comment Edited] (CB-8084) Push Notifications code included
by default
[ https://issues.apache.org/jira/browse/CB-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319444#comment-14319444 ]
Shazron Abdullah edited comment on CB-8084 at 2/13/15 2:07 AM:
---------------------------------------------------------------
I'm reluctant to put this code in since it will be ripped out later in 4.0. The 3.8.0 release is long overdue and since it doesn't really affect upload (warning for now) I'd rather leave it be for now.
What I can do is wrap the remote/local notification code in the AppDelegate with:
{code}
#ifndef DISABLE_PUSH_NOTIFICATIONS
// delegate code here
#endif
{code}
This means by default the delegate functions are enabled, like always (backwards compatible). Through a build hook (which can be installed through a plugin, or just copied into the project), the code that was in the pull request can be run where it adds the DISABLE_PUSH_NOTIFICATIONS = 1 in the build.xcconfig file.
was (Author: shazron):
I'm reluctant to put this code since it will be ripped out later in 4.0. The 3.8.0 release is long overdue and since it doesn't really affect upload (warning for now) I'd rather leave it be for now.
What I can do is wrap the remote/local notification code in the AppDelegate with:
{code}
#ifndef DISABLE_PUSH_NOTIFICATIONS
// delegate code here
#endif
{code}
This means by default the delegate functions are enabled, like always (backwards compatible). Through a build hook (which can be installed through a plugin, or just copied into the project), the code that was in the pull request can be run where it adds the DISABLE_PUSH_NOTIFICATIONS = 1 in the build.xcconfig file.
> Push Notifications code included by default
> -------------------------------------------
>
> Key: CB-8084
> URL: https://issues.apache.org/jira/browse/CB-8084
> Project: Apache Cordova
> Issue Type: Bug
> Affects Versions: 3.5.0
> Reporter: Jacob Weber
>
> When creating a new Cordova app using the CLI, it adds code to AppDelegate.m for Push Notifications. This causes Apple to issue a warning when you submit the app, if your provisioning profile doesn't have Push Notifications enabled:
> {quote}
> Missing Push Notification Entitlement - Your app appears to include API used to register with the Apple Push Notification service, but the app signature's entitlements do not include the "aps-environment" entitlement. If your app uses the Apple Push Notification service, make sure your App ID is enabled for Push Notification in the Provisioning Portal, and resubmit after signing your app with a Distribution provisioning profile that includes the "aps-environment" entitlement. See "Provisioning and Development" in the Local and Push Notification Programming Guide for more information. If your app does not use the Apple Push Notification service, no action is required. You may remove the API from future submissions to stop this warning. If you use a third-party framework, you may need to contact the developer for information on removing the API.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org