[jira] [Commented] (YARN-1750) TestNodeStatusUpdater#testNMRegistration is incorrect in test case

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973301#comment-13973301 ] 

Hudson commented on YARN-1750:
------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #5533 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5533/])
YARN-1750. TestNodeStatusUpdater#testNMRegistration is incorrect in test case. (Wangda Tan via junping_du) (junping_du: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1588343)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java


> TestNodeStatusUpdater#testNMRegistration is incorrect in test case
> ------------------------------------------------------------------
>
>                 Key: YARN-1750
>                 URL: https://issues.apache.org/jira/browse/YARN-1750
>             Project: Hadoop YARN
>          Issue Type: Test
>          Components: nodemanager
>            Reporter: Ming Ma
>            Assignee: Wangda Tan
>             Fix For: 2.4.1
>
>         Attachments: YARN-1750.patch
>
>
> This test case passes. However, the test output log has
> java.lang.AssertionError: Number of applications should only be one! expected:<1> but was:<2>
>         at org.junit.Assert.fail(Assert.java:93)
>         at org.junit.Assert.failNotEquals(Assert.java:647)
>         at org.junit.Assert.assertEquals(Assert.java:128)
>         at org.junit.Assert.assertEquals(Assert.java:472)
>         at org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdater$MyResourceTracker.nodeHeartbeat(TestNodeStatusUpdater.java:267)
>         at org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl$1.run(NodeStatusUpdaterImpl.java:469)
>         at java.lang.Thread.run(Thread.java:695)
> TestNodeStatusUpdater.java has invalid asserts.
>       } else if (heartBeatID == 3) {
>         // Checks on the RM end
>         Assert.assertEquals("Number of applications should only be one!", 1,
>             appToContainers.size());
>         Assert.assertEquals("Number of container for the app should be two!",
>             2, appToContainers.get(appId2).size());
> We should fix the assert and add more check to the test.



--
This message was sent by Atlassian JIRA
(v6.2#6252)