You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2019/12/21 15:24:22 UTC
[GitHub] [groovy] danielsun1106 opened a new pull request #1129:
GROOVY-9352: Static compilation fails with NoClassDefFoundError
danielsun1106 opened a new pull request #1129: GROOVY-9352: Static compilation fails with NoClassDefFoundError
URL: https://github.com/apache/groovy/pull/1129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #1129: GROOVY-9352:
Static compilation fails with NoClassDefFoundError
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on issue #1129: GROOVY-9352: Static compilation fails with NoClassDefFoundError
URL: https://github.com/apache/groovy/pull/1129#issuecomment-568212156
@melix Thanks for your reviewing. I'll port the fix to 2_5_X later. It's very late for me to sleep... (5:09 a.m.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] eric-milles commented on issue #1129: GROOVY-9352: Static
compilation fails with NoClassDefFoundError
Posted by GitBox <gi...@apache.org>.
eric-milles commented on issue #1129: GROOVY-9352: Static compilation fails with NoClassDefFoundError
URL: https://github.com/apache/groovy/pull/1129#issuecomment-568214280
This is a lot of change with very little review. Already merged into 3.0... The issue is hardly 7 hours old.
Why isn't a change of this scope on a branch that has others able to pull down and try out to judge benefit vs cost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] PascalSchumacher commented on issue #1129: GROOVY-9352:
Static compilation fails with NoClassDefFoundError
Posted by GitBox <gi...@apache.org>.
PascalSchumacher commented on issue #1129: GROOVY-9352: Static compilation fails with NoClassDefFoundError
URL: https://github.com/apache/groovy/pull/1129#issuecomment-569135457
`LazyConstructorNode` etc. override `hashCode`. Shouldn't `equals` also be overriden? Or am I missing something?
Thanks,
Pascal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 merged pull request #1129: GROOVY-9352:
Static compilation fails with NoClassDefFoundError
Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1129: GROOVY-9352: Static compilation fails with NoClassDefFoundError
URL: https://github.com/apache/groovy/pull/1129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #1129: GROOVY-9352:
Static compilation fails with NoClassDefFoundError
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on issue #1129: GROOVY-9352: Static compilation fails with NoClassDefFoundError
URL: https://github.com/apache/groovy/pull/1129#issuecomment-569179205
@PascalSchumacher I will refine it later. Thanks for your reviewing :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services