You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Dawid Weiss (JIRA)" <ji...@apache.org> on 2014/12/05 19:15:13 UTC
[jira] [Commented] (LUCENE-6095) Remove
RamUsageTester.IdentityHashSet
[ https://issues.apache.org/jira/browse/LUCENE-6095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235830#comment-14235830 ]
Dawid Weiss commented on LUCENE-6095:
-------------------------------------
It's there because newSetFromMap wastes additional (unnecessary) memory.
> Remove RamUsageTester.IdentityHashSet
> -------------------------------------
>
> Key: LUCENE-6095
> URL: https://issues.apache.org/jira/browse/LUCENE-6095
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Trivial
> Attachments: LUCENE-6095.patch
>
>
> RamUsageTester has an implementation of an identity hash set. I am not sure why it is there but now that RamUsageTester can only be used in the context of tests (ie. memory usage or speed are less of a concern) I think we can switch to Collections.newSetFromMap(new IdentityHashMap<>())?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org