[jira] [Comment Edited] (KAFKA-10035) Improve the AbstractResetIntegrationTest

["Matthias J. Sax (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158501#comment-17158501 ] 

Matthias J. Sax edited comment on KAFKA-10035 at 7/16/20, 1:10 AM:
-------------------------------------------------------------------

Hello [~feyman], [~chia7712], [~mjsax], [~ableegoldman]

PR with possible fix: [https://github.com/apache/kafka/pull/9028]

In case this approach is correct could you please assign this ticket to me, I would like to go on with it. In any case I would appreciate the feedback.


was (Author: serj567):
Hello [~feyman], [~chia7712], [~mjsax], [~ableegoldman]

PR with possible fix: [https://github.com/apache/kafka/pull/9022]

In case this approach is correct could you please assign this ticket to me, I would like to go on with it. In any case I would appreciate the feedback.

> Improve the AbstractResetIntegrationTest
> ----------------------------------------
>
>                 Key: KAFKA-10035
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10035
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, unit tests
>            Reporter: feyman
>            Assignee: Sergei
>            Priority: Minor
>
> In the test: AbstractResetIntegrationTest, there are several places like below:
>  
> {code:java}
> streamsConfig.put(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG, "" + STREAMS_CONSUMER_TIMEOUT * 100);
> {code}
> which leverage `Long` to `String` conversion as a workaround.
>  
> {code:java}
> streamsConfig.put(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG, STREAMS_CONSUMER_TIMEOUT * 100);
> {code}
> or exception will be thrown if it is like:
> {code:java}
> {{org.apache.kafka.common.config.ConfigException: Invalid value 200000 for configuration session.timeout.ms: Expected value to be a 32-bit integer, but it was a java.lang.Long
>  at org.apache.kafka.common.config.ConfigDef.parseType(ConfigDef.java:672)
>  at org.apache.kafka.common.config.ConfigDef.parseValue(ConfigDef.java:474)
>  at org.apache.kafka.common.config.ConfigDef.parse(ConfigDef.java:467)
>  at org.apache.kafka.common.config.AbstractConfig.<init>(AbstractConfig.java:108)
>  at org.apache.kafka.common.config.AbstractConfig.<init>(AbstractConfig.java:129)
>  at org.apache.kafka.clients.consumer.ConsumerConfig.<init>(ConsumerConfig.java:606)
>  at org.apache.kafka.clients.consumer.KafkaConsumer.<init>(KafkaConsumer.java:630)
>  at org.apache.kafka.streams.processor.internals.DefaultKafkaClientSupplier.getRestoreConsumer(DefaultKafkaClientSupplier.java:56)
>  at org.apache.kafka.streams.processor.internals.StreamThread.create(StreamThread.java:313)
>  at org.apache.kafka.streams.KafkaStreams.<init>(KafkaStreams.java:766)
>  at org.apache.kafka.streams.KafkaStreams.<init>(KafkaStreams.java:652)
>  at org.apache.kafka.streams.KafkaStreams.<init>(KafkaStreams.java:562)
>  at org.apache.kafka.streams.integration.AbstractResetIntegrationTest.testResetWhenLongSessionTimeoutConfiguredWithForceOption(AbstractResetIntegrationTest.java:270)
>  at org.apache.kafka.streams.integration.ResetIntegrationTest.testResetWhenLongSessionTimeoutConfiguredWithForceOption(ResetIntegrationTest.java:77)}}{code}
> This may not seem very intuitive and need enhancement. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)